Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gp info command #10797

Closed
loujaybee opened this issue Jun 21, 2022 · 6 comments · Fixed by #13537
Closed

Create gp info command #10797

loujaybee opened this issue Jun 21, 2022 · 6 comments · Fixed by #13537
Assignees
Labels
component: gp cli team: IDE team: workspace Issue belongs to the Workspace team type: improvement Improves an existing feature or existing code

Comments

@loujaybee
Copy link
Member

loujaybee commented Jun 21, 2022

Create a gp info command that includes:

  • Workspace class name
  • Resources available (CPU/RAM/Storage)
  • URL
  • Workspace cluster and region

To replace the use of the respective environment variables.


Original description

Deprecate all "default environment variables" in favour of either gp cli wrapper, or namespaced variables.

We currently have listed "default" environment variables listed in the documentation. For a user to understand which environment variables they can rely on, they have to bounce from the docs to the product. It would be good if they can discover these variables more easily using an approach more familiar to "linux", e.g. through gp, and/or man pages.

Some preferred experience could be:

  1. Move all default environment variables under gp
  2. Namespace protected environment variabes with a prefix, etc to make it clear which ones can be relied upon.

Examples:

Important: This doesn't mean breaking backwards compatibility, or removing the env variables (yet) but introducing an alias, or a clear API, such as the gp wrapper, to open the opportunity for future removal as an integration point within the product.

Related issues:

@loujaybee
Copy link
Member Author

Design TBD, some suggestions for the gp interface (from @akosyakov):

Maybe we can have gp info which basically prints information exposed via supervisor info with some flags which is a selector. I am not sure about idea of adding a new command for each bit of information. i.e gp info --filter=workspaceClass prints workspace class, maybe --json to provide machine-readable.

@loujaybee
Copy link
Member Author

loujaybee commented Jun 21, 2022

Not sure which labels are best for this issue, would appreciate it being tagged up 🙏

@gitpod-io/engineering-workspace could you label this up with any labels you think appropriate? Adding to the workspace inbox for labelling, but not urgent, more a long-term suggestion that we can gradually move towards.

@akosyakov
Copy link
Member

To clarify: env vars are internal implementations of supervisor, they are there, but they should not be surfaced to user in docs, rather gp cli.

@atduarte atduarte added the type: improvement Improves an existing feature or existing code label Jul 25, 2022
@atduarte
Copy link
Contributor

@loujaybee Are there other env vars that you believe should be converted into a gp command other than the workspace class / info?

@loujaybee
Copy link
Member Author

@atduarte not that i know off the top of my head, would need to audit / look through the current variables.

@atduarte atduarte changed the title Deprecate the "default environment variables" (from a support standpoint) Create gp info command Aug 31, 2022
@atduarte
Copy link
Contributor

atduarte commented Aug 31, 2022

@loujaybee based on that, changed the issue to be more actionable to the workspace team. LMKWYT. I'm aware we are modifying the gp top to include the workspace class name, but this seems worth it nonetheless.

@WVerlaek WVerlaek self-assigned this Oct 3, 2022
@WVerlaek WVerlaek moved this to In Progress in 🌌 Workspace Team Oct 3, 2022
Repository owner moved this from In Progress to Awaiting Deployment in 🌌 Workspace Team Oct 5, 2022
@kylos101 kylos101 moved this from Awaiting Deployment to In Validation in 🌌 Workspace Team Oct 5, 2022
@WVerlaek WVerlaek moved this from In Validation to Done in 🌌 Workspace Team Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: gp cli team: IDE team: workspace Issue belongs to the Workspace team type: improvement Improves an existing feature or existing code
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants