Skip to content

minor: Do not promote extension if it's already installed #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kreyren opened this issue Jan 31, 2020 · 7 comments
Closed

minor: Do not promote extension if it's already installed #1163

Kreyren opened this issue Jan 31, 2020 · 7 comments
Labels
component: browser-extension meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working

Comments

@Kreyren
Copy link

Kreyren commented Jan 31, 2020

Currently gitpod promotes the gitpod extension even if it's already installed which i find annoying -> Suggesting it to not display if extension is already installed

image

@svenefftinge svenefftinge added the type: bug Something isn't working label Jan 31, 2020
@jankeromnes
Copy link
Contributor

jankeromnes commented Jan 31, 2020

Thanks! I was able to reproduce this.

For some reason in my Firefox Nightly on Mac OS, the Gitpod extension is installed and enabled, but it doesn't seem to do anything (no Gitpod logo in the top right browser bar).

EDIT: The extension actually works on GitHub. Chrome also shows the (active) Gitpod logo. However Gitpod loading screen still shows the extension hint. I guess the extension check is broken.

@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 2, 2020

This is no longer reproducible. I'm only seeing the prompt when I don't have the browser extension installed. Closing this. /cc @Kreyren @jankeromnes

@gtsiolis gtsiolis closed this as completed Nov 2, 2020
@gtsiolis
Copy link
Contributor

gtsiolis commented Nov 4, 2020

Just run into the prompt a couple of times while having the extension installed. Let's reopen this. @jankeromnes do you know if we no longer check this?

@gtsiolis gtsiolis reopened this Nov 4, 2020
@stale
Copy link

stale bot commented Mar 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 17, 2021
@LinqLover
Copy link

I don't think this has been resolved?

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Mar 17, 2021
@stale
Copy link

stale bot commented Jun 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jun 15, 2021
@gtsiolis
Copy link
Contributor

Closing this as it's no longer relevant. 📕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: browser-extension meta: stale This issue/PR is stale and will be closed soon type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants