Skip to content

Decrease spacing between the timestamp table header and the sorting icon #12221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Aug 19, 2022 · 4 comments
Closed
Assignees
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Aug 19, 2022

Problem to solve

Following up from #12135 (comment), we need to decrease spacing between the timestamp table header and the sorting icon.

BEFORE AFTER
header-before header-after

Proposal

Change the spacing using the following snippet:

diff --git a/components/dashboard/src/teams/TeamUsage.tsx b/components/dashboard/src/teams/TeamUsage.tsx
index f78fee1f2..15349754a 100644
--- a/components/dashboard/src/teams/TeamUsage.tsx
+++ b/components/dashboard/src/teams/TeamUsage.tsx
@@ -239,7 +239,7 @@ function TeamUsage() {
                                             >
                                                 Timestamp
                                                 <SortArrow
-                                                    className={`ml-2 h-4 w-4 my-auto ${
+                                                    className={`ml-1 h-4 w-4 my-auto ${
                                                         isStartedTimeDescending ? "" : " transform rotate-180"
                                                     }`}
                                                 />
@gtsiolis gtsiolis added help wanted component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Aug 19, 2022
@ashwinair
Copy link

Hi, @gtsiolis I'm new to the Gitpod community, can I work on this issue?

also can you please share some reading to help me understand how to contribute?

was trying to do it with Gitpod itself but found it difficult to navigate as a beginner. :)

@gtsiolis
Copy link
Contributor Author

Hi @ashwinair!

I'm new to the Gitpod community, can I work on this issue?

Welcome and yes!

... was trying to do it with Gitpod itself but found it difficult to navigate as a beginner.

Our contributor experience still needs some improvements to make it clearer and easier for contributors from the wider community, see #6466.

In the meantime, the easiest way to get started is to open a new pull request and someone from the team will spin up a new preview environment that deploys the app itself.

Regarding this change, it's a trivial fix—I've added in the issue description how you could tackle this. 💡

@ashwinair
Copy link

ashwinair commented Aug 20, 2022

Regarding this change, it's a trivial fix—I've added in the issue description how you could tackle this. 💡

Thanks, @gtsiolis!

I made the change as you suggested and submitted my PR !!

@gtsiolis
Copy link
Contributor Author

Closing this as it's no longer relevant.
Thanks @ashwinair for giving this a go in #12244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
2 participants