Skip to content

Use a different sorting icon color on dark theme #12225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Aug 19, 2022 · 5 comments
Closed

Use a different sorting icon color on dark theme #12225

gtsiolis opened this issue Aug 19, 2022 · 5 comments
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Following up from #12135 (comment):

Ideally, we could use a different color for the SVG icon on light and dark theme but it's ok to leave this out of the scope here. FWIW, gray-400 for light and gray-500 for dark theme.

Icon (Light) Icon (Dark) (BEFORE) Icon (Dark) (AFTER)
header-light header-dark-before header-dark-after
@gtsiolis gtsiolis added help wanted component: dashboard type: improvement Improves an existing feature or existing code team: webapp Issue belongs to the WebApp team labels Aug 19, 2022
@priyal32
Copy link

Hi! is this issue still open to work on?

@gtsiolis
Copy link
Contributor Author

@priyal32 Yes! Feel free to open a pull request and reference this issue. 🏓

@priyal32
Copy link

@gtsiolis I'm new to open source and this community so I'm kinda having trouble locating the file. As I understand it should be in one of the folders in gitpod/components/dashboard/src but I'm not sure where to go from there. Do I go to components and then arrow.tsx? Any help would be appreciated!

@priyal32
Copy link

@gtsiolis I think I found the file (https://github.com/gitpod-io/gitpod/blob/main/components/dashboard/src/components/UsageView.tsx) but the sort arrow is not imported. I see that it was imported in like one of the previous versions?

@gtsiolis
Copy link
Contributor Author

Nice catch, @priyal32! ⚾

We've recently removed the sorting functionality but we'll probably come back to this later. Let me close this for now as this is no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

2 participants