Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alert on FinalizeInvoice errors #13034

Closed
easyCZ opened this issue Sep 16, 2022 · 7 comments
Closed

Alert on FinalizeInvoice errors #13034

easyCZ opened this issue Sep 16, 2022 · 7 comments
Assignees
@easyCZ
Labels
feature: billing team: webapp Issue belongs to the WebApp team

Comments

@easyCZ
Copy link
Member

easyCZ commented Sep 16, 2022

When BillingService.FinalizeInvoice errors, alert on it.
@easyCZ easyCZ moved this from Scheduled to In Progress in 🍎 WebApp Team Sep 16, 2022
@easyCZ easyCZ self-assigned this Sep 16, 2022
@easyCZ easyCZ mentioned this issue Sep 16, 2022
Merged
1 task
@easyCZ
Copy link
Member Author

easyCZ commented Sep 16, 2022

To do this, it's not enough to alert on the FinalizeInvoice RPC (on gRPC), we also need to alert on the incoming webhook endpoint - that is on public-api-server

To do that, we need to track metrics from baseserver - #13040

@easyCZ
Copy link
Member Author

easyCZ commented Sep 19, 2022

Currently blocked on fixes to observability release pipeline.

@easyCZ
Copy link
Member Author

easyCZ commented Sep 20, 2022

Alerts are configured here - #13109
Runbooks are still needed.

@easyCZ
Copy link
Member Author

easyCZ commented Sep 20, 2022

Alert on stripe webhook: #13119
Runbook for stripe webhook: https://github.com/gitpod-io/runbooks/pull/391

Once these land, we can close this issue.

@easyCZ
Copy link
Member Author

easyCZ commented Sep 23, 2022

Alerting rules failed silently during deployment - #13255 fixes that

@easyCZ easyCZ mentioned this issue Sep 26, 2022
Closed
@easyCZ
Copy link
Member Author

easyCZ commented Sep 26, 2022

Alerts have now propagated.

Image

@easyCZ
Copy link
Member Author

easyCZ commented Sep 26, 2022

This is now complete.

@easyCZ easyCZ closed this as completed Sep 26, 2022
Repository owner moved this from In Progress to Done in 🍎 WebApp Team Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@easyCZ easyCZ

Labels
feature: billing team: webapp Issue belongs to the WebApp team
Projects
🍎 WebApp Team
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@easyCZ