Skip to content

KOTS: prerender yaml & validate patch files, prior to proceeding with deploy #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kylos101 opened this issue Sep 21, 2022 · 2 comments
Closed

Comments

@kylos101
Copy link
Contributor

Is your feature request related to a problem? Please describe

Customer patch files do not get validated before we deploy. This can be painful during outage windows, where they're trying to proceed with an upgrade, have a malformed file, but don't necessarily know why the upgrade is failing.

Describe the behaviour you'd like

A pre-flight check should fail if the patch file causes rendered yaml to fail validation. This would ideally prevent the upgrade from continuing and clearly show the administrator what failed.

Describe alternatives you've considered

n/a

Additional context

@kylos101
Copy link
Contributor Author

@lucasvaltl @corneliusludmann a customer ran into this issue recently when doing an update of a self-hosted Gitpod installation.

cc: @atduarte @aledbf

@corneliusludmann
Copy link
Contributor

Thanks, @kylos101 for raising this feature request. I'll close this as a duplicate of #12015.

We couldn't implement this easily in the past. However, the refactoring @mrsimonemms did recently enables this. We will have this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants