Skip to content

List all (or paginate) access tokens view #15098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #14280
easyCZ opened this issue Dec 1, 2022 · 3 comments · Fixed by #15180
Closed
Tracked by #14280

List all (or paginate) access tokens view #15098

easyCZ opened this issue Dec 1, 2022 · 3 comments · Fixed by #15180
Assignees
Labels
feature: public-api Issues relating to Public API team: webapp Issue belongs to the WebApp team

Comments

@easyCZ
Copy link
Member

easyCZ commented Dec 1, 2022

Currently we're only fetching the first page of 100 records to show for the tokens. Either we should paginate the view, or we should for now fetch all of them when loading the data.

CC @gtsiolis if you have ideas on this

@easyCZ easyCZ added the team: webapp Issue belongs to the WebApp team label Dec 1, 2022
@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 1, 2022

@easyCZ Some thoughts below:

  1. Paginating sounds like the best way forward.
  2. I'd avoid loading them all at once.
  3. I'd also hide the pagination element altogether if the records are less than the page size (100).
  4. Maybe also consider paginating at 50, 25, or even 10 entries if it makes sense.

@easyCZ
Copy link
Member Author

easyCZ commented Dec 1, 2022

The API supports any page size between 1 and 100.

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 1, 2022

@easyCZ Let's go with a page size of 50 as we do with the usage page and adjust if needed.

💡 tip: There's already a pagination component ready to use, see components/src/Pagination folder.

function Pagination(props: PaginationProps) {

@laushinka laushinka self-assigned this Dec 5, 2022
@laushinka laushinka moved this to In Progress in 🍎 WebApp Team Dec 5, 2022
Repository owner moved this from In Progress to In Validation in 🍎 WebApp Team Dec 6, 2022
@laushinka laushinka moved this from In Validation to Done in 🍎 WebApp Team Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: public-api Issues relating to Public API team: webapp Issue belongs to the WebApp team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants