Skip to content

Stop prebuilds from running when a project is added on a new team with no paid plans or available credits #15798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtsiolis opened this issue Jan 17, 2023 · 3 comments
Assignees
Labels
feature: billing team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Jan 17, 2023

Bug description

Prebuilds for some projects on teams with no active billing or available credits continue to run against the user who added the project. One case involves a GitLab repository where the individual user added the repository as a project, using a webhook, the default method for enabling prebuilds for GitLab repositories.

See relevant discussion (internal). Cc @jldec @svenefftinge

Steps to reproduce

Haven't tested this, but this could be probably reproduced by adding a GitLab repository as a project on a new team with no active paid plan, which enables prebuilds for that project.

@gtsiolis gtsiolis added type: bug Something isn't working team: webapp Issue belongs to the WebApp team feature: billing labels Jan 17, 2023
@gtsiolis gtsiolis changed the title Stop prebuilds from consuming a negative credits balance on personal billing when the project belongs to a team with no available credits Stop prebuilds from running when a project is added on a new team with no paid plans or available credits Jan 17, 2023
@jldec
Copy link
Contributor

jldec commented Jan 18, 2023

The current behavior was by design, making prebuilds usable by members of the community, even when those prebuilds are managed through a project in a team with no payment configured.

Once attribution is limited to teams only (see #15665) and we have a mechanism to keep supporting OSS projects, this behavior will be revisited.

@geropl
Copy link
Member

geropl commented Feb 13, 2023

Should be covered by: #16347

@geropl geropl closed this as completed Feb 13, 2023
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Feb 13, 2023
@gtsiolis
Copy link
Contributor Author

Thanks for coming back to this, @geropl! 🏀

@geropl geropl moved this from In Validation to Done in 🍎 WebApp Team Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: billing team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants