Skip to content

[dashboard] Unify Alert components & fix for dark theme #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jankeromnes opened this issue Apr 19, 2021 · 1 comment · Fixed by #4020
Closed

[dashboard] Unify Alert components & fix for dark theme #3996

jankeromnes opened this issue Apr 19, 2021 · 1 comment · Fixed by #4020
Assignees
@jankeromnes
Labels
component: dashboard type: improvement Improves an existing feature or existing code user experience

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Apr 19, 2021 •
edited
Loading

Bug description

Currently, there are various implementations of the Alert component in the dashboard.

This causes them to appear non-uniform, especially in dark theme:

Screenshot 2021-04-19 at 15 19 29

Screenshot 2021-04-19 at 15 23 49

Screenshot 2021-04-19 at 15 18 54

Screenshot 2021-04-19 at 15 28 08

Screenshot 2021-04-19 at 15 28 21

Steps to reproduce

  1. Use dashboard in dark theme

Expected behavior

No response

Example repository

No response
@jankeromnes
Copy link
Contributor Author

(Requires custom Werft preview with payments enabled, which makes testing this a bit tricky, so removing good-first-issue again.)

@jankeromnes jankeromnes self-assigned this Apr 20, 2021
@jankeromnes jankeromnes added this to the April 2021 milestone Apr 20, 2021
@jankeromnes jankeromnes mentioned this issue Apr 20, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankeromnes jankeromnes

Labels
component: dashboard type: improvement Improves an existing feature or existing code user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dashboard] Unify and standardize InfoBox and AlertBox components gitpod-io/gitpod
1 participant
@jankeromnes