Skip to content

registry-facade should use reg.<prefix>.<domain>, not reg.<domain> #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meysholdt opened this issue Apr 29, 2021 · 5 comments
Closed

registry-facade should use reg.<prefix>.<domain>, not reg.<domain> #4114

meysholdt opened this issue Apr 29, 2021 · 5 comments
Labels
component: registry-facade meta: stale This issue/PR is stale and will be closed soon type: incident Gitpod.io service is unstable

Comments

@meysholdt
Copy link
Member

registry-facade should use reg.<prefix>.<domain>, not reg.<domain>, because registry-facade runs inside a pluggable workspaces cluster which lives under <prefix>.<domain>. Making use of reg.<domain> interferes with the domain if the meta clusters.

@meysholdt meysholdt added the type: incident Gitpod.io service is unstable label May 27, 2021
@meysholdt
Copy link
Member Author

this just caused certificate renewal to fail once in the US clusters.
Commenting to bring this back up.

@meysholdt
Copy link
Member Author

got bitten by this again.

@csweichel
Copy link
Contributor

I reckon the actual issue that we're relying on the public HTTPS certificates for registry-facade.
We've recently started to move to self-signed certs in this case.

@aledbf how much trouble would it be to port your changes over to main?

(removing from groundwork until this becomes actionable)

@aledbf
Copy link
Member

aledbf commented Jul 29, 2021

@csweichel I need to sync in #4592 the latest changes from https://github.com/aledbf/gitpod-chart-cleanup

@stale
Copy link

stale bot commented Oct 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 28, 2021
@stale stale bot closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: registry-facade meta: stale This issue/PR is stale and will be closed soon type: incident Gitpod.io service is unstable
Projects
None yet
Development

No branches or pull requests

3 participants