Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never make ports public unless explicitly configured #4159

Closed
corneliusludmann opened this issue May 6, 2021 · 0 comments · Fixed by #4548
Closed

Never make ports public unless explicitly configured #4159

corneliusludmann opened this issue May 6, 2021 · 0 comments · Fixed by #4548
Assignees
@corneliusludmann
Labels
feature: ports priority: must have This issue must be fixed before others - use sparingly type: improvement Improves an existing feature or existing code
Milestone
[backlog] June 2021

Comments

@corneliusludmann
Copy link
Contributor

Currently, ports that are listed in the .gitpod.yaml file are public by default. That means everyone that knows the port URL can access them without authentication/authorization. We do this for backward compatibility reasons.

However, public ports can be a security reason in some cases. Therefore, we should break backward compatibility in favor of more secure defaults and make ports public only when the user has configured it explicitly with the visibility property in the .gitpod.yaml file or by clicking the “Make Public” button.

We should probably mention this change in the changelog dialog to inform our users.
@corneliusludmann corneliusludmann added feature: ports type: improvement Improves an existing feature or existing code labels May 6, 2021
@csweichel csweichel added this to the [backlog] June 2021 milestone May 6, 2021
@csweichel csweichel added the priority: must have This issue must be fixed before others - use sparingly label May 6, 2021
@corneliusludmann corneliusludmann self-assigned this Jun 1, 2021
This was referenced Jun 18, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corneliusludmann corneliusludmann

Labels
feature: ports priority: must have This issue must be fixed before others - use sparingly type: improvement Improves an existing feature or existing code
Projects
None yet
Milestone
[backlog] June 2021
Development

Successfully merging a pull request may close this issue.

[supervisor] Make ports configured in .gitpod.yml private by default gitpod-io/gitpod
2 participants
@csweichel @corneliusludmann