Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to delete multiple or all workspaces #4233

Closed
gtsiolis opened this issue May 18, 2021 · 5 comments · Fixed by #10450 or #10676
Closed

Make it easier to delete multiple or all workspaces #4233

gtsiolis opened this issue May 18, 2021 · 5 comments · Fixed by #10450 or #10676
Labels
component: dashboard meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team type: feature request New feature or request user experience

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented May 18, 2021

Problem to solve

Although workspaces eventually time out and stopped workspaces are getting deleted according to the garbage collection, sometimes a user would like to manually delete multiple or all workspaces regarding running status.

See also relevant discussion (internal). /cc @princerachit @corneliusludmann

Proposal

TBD (To be discussed)

First MVC (Minimum Viable Change) could be to add replace the status indicator with a checkbox on hover so that users can select multiple workspaces and then click on the Delete button. Additionally, a checkbox at the top of the list to select all and delete all could be also helpful.

An early design spec could be the following:

Possible solution for multiple workspace deletion
image
@princerachit
Copy link
Contributor

Thanks for creating the issue @gtsiolis . I think adding a checkbox is better than replacing the status indicator with checkbox.
If we replace the status indicator, we are losing information from the dashboard that we initially used to qualify for action. If I accidentally click on an active ws, I have no way of verifying an active ws.

@apolopena
Copy link

@gtsiolis Awesome this is on the fix it list now. I agree with @princerachit about not replacing the status icons.
A possible MVC approach here could be to have a 'Delete All Inactives' button that when clicked prompts the user in a modal before deleting all inactive workspaces.

@stale
Copy link

stale bot commented Aug 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 17, 2021
@apolopena
Copy link

Someone please mark this the with never-stale label

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Aug 18, 2021
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Aug 18, 2021
@gtsiolis
Copy link
Contributor Author

DONE, phew! Thanks, @apolopena! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team type: feature request New feature or request user experience
Projects
None yet
3 participants