Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format elapsed Prebuild time better below the Prebuild Logs ("05:06" instead of "306s") #5525

Closed
jankeromnes opened this issue Sep 3, 2021 · 1 comment
Closed

Format elapsed Prebuild time better below the Prebuild Logs ("05:06" instead of "306s") #5525

jankeromnes opened this issue Sep 3, 2021 · 1 comment
Assignees
@jankeromnes
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. roadmap item: teams & projects type: improvement Improves an existing feature or existing code user experience

Comments

@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 3, 2021 •
edited
Loading

The specs (#4423)

Screenshot 2021-09-03 at 14 26 10

The current implementation (after #5474)

#5474 (comment)

issue: This is currently showing duration as seconds like 5s but this could look confusing when showing time duration longer than a minute. For example, 306s. Ideally this could surface time duration for 306s as like 05:06 as described in the initial specs in #4948 (comment). However, it should be fine to resolve this in a follow up issue. 🏓

5s 306s
duration-1 duration-2
@jankeromnes jankeromnes added user experience component: dashboard type: improvement Improves an existing feature or existing code roadmap item: teams & projects 🧑‍🚀 crew: teams and projects feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Sep 3, 2021
@jankeromnes jankeromnes mentioned this issue Sep 3, 2021
Merged
7 tasks
@jankeromnes jankeromnes self-assigned this Jan 3, 2022
@jankeromnes
Copy link
Contributor Author

Fixed in 3873545

@jankeromnes jankeromnes moved this to Done in 🍎 WebApp Team Jan 3, 2022
@jldec jldec removed this from 🍎 WebApp Team Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jankeromnes jankeromnes

Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. roadmap item: teams & projects type: improvement Improves an existing feature or existing code user experience
Projects
No open projects
🍊 Feature: Teams & Projects
Status: Low hanging fruits 🍒
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gtsiolis @jankeromnes