Skip to content

Do now allow prebuild re-triggering on successful prebuilds #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gtsiolis opened this issue Sep 21, 2021 · 2 comments
Closed

Do now allow prebuild re-triggering on successful prebuilds #5784

gtsiolis opened this issue Sep 21, 2021 · 2 comments
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

Problem to solve

Following up on the relevant discussion (internal) about triggering prebuilds, we should not allow users to trigger prebuilds for successful prebuilds. Cc @AlexTugarev @jankeromnes @svenefftinge

Good point! Let’s not allow retriggering when READY.

Leaving the trigger option could create more confusion, especially as 🅰️ the action verb changes remains the same regardless if the prebuild has succeded or failed and 🅱️ the verb changes on Branches and Prebuilds page (see #5008).
@gtsiolis gtsiolis added component: dashboard feature: prebuilds type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Sep 21, 2021
@AlexTugarev
Copy link
Member

This is already done. I'm too lazy to search for the PR from @jankeromnes.

@gtsiolis
Copy link
Contributor Author

Thanks @AlexTugarev! FWIW, This was resolved as part of #5836.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: dashboard feature: prebuilds feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
No open projects
🍊 Feature: Teams & Projects
Status: Low hanging fruits 🍒
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gtsiolis @AlexTugarev