Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR diff does not always recognize PR #618

Closed
akosyakov opened this issue Jun 17, 2019 · 3 comments
Closed

PR diff does not always recognize PR #618

akosyakov opened this issue Jun 17, 2019 · 3 comments
Labels
meta: stale This issue/PR is stale and will be closed soon

Comments

@akosyakov
Copy link
Member

See There is no pull request.:

Screen Shot 2019-06-17 at 12 45 22

It's reproducible for: eclipse-theia/theia#5326
@akosyakov
Copy link
Member Author

akosyakov commented Jun 17, 2019 •
edited
Loading

Also files cannot be opened from the diff view.

As a workaround one can reopen it from the PR view then it works.

@akosyakov
Copy link
Member Author

akosyakov commented Jun 17, 2019 •
edited
Loading

Probably the important detail is that i've rebased the PR for review after starting the workspace.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Oct 4, 2020
@stale stale bot closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta: stale This issue/PR is stale and will be closed soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akosyakov