-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support scopes flag in gp env
#6339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/assign |
@loujaybee i think it need discussion current unset
current get can get environment variables with a repository pattern of */foo, foo/* or */*. Should we keep it the same? Or do we also need to add the --repo parameter? |
@loujaybee have any ideas? |
/unassign |
@iQQBot maybe on first iteration just add the ability to set scope for set and leave the rest unchanged? nevermind — see next comment. I thought about it some more |
Maybe keep this in mind too: We might someday want to pass a regex for the So maybe
|
@loujaybee , @chuck-alt-delete Hi! I'm new to the Gitpod community. Can I please take this up? |
@m-Bilal sure thing 👍 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Not stale 😄 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Currently
gp env
allows you to set an environment variable, but it automatically sets the scope (of the environment variable) as the current repo, we should extend the command to allow any wildcard to be input.Steps to replicate:
gp env SCOPE_TEST=temp
e.g.
The default behaviour makes sense, but we should consider extending with a flag such as
--scope=repo
which will allow the user to specify the scopes of the environment variable.Related: #6308 (comment)
The text was updated successfully, but these errors were encountered: