Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show prebuild configuration state on the project prebuilds page #7010

Open
Tracked by #7812
gtsiolis opened this issue Dec 2, 2021 · 4 comments
Open
Tracked by #7812

Show prebuild configuration state on the project prebuilds page #7010

gtsiolis opened this issue Dec 2, 2021 · 4 comments
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@gtsiolis
Copy link
Contributor

gtsiolis commented Dec 2, 2021

Problem to solve

Currently, when removing (or reconfiguring) the GitHub app or removing the GitLab webhook the project, there's no feedback to the user the GitHub app needs to be reconfigured or the webhook is missing. See also #7009.

(Revised) Proposal

From comment

MVC to help users understand the understand the state of a prebuild configuration for a specific project:

Could we show a repository prebuild configuration status on /projects/<project-name>/prebuilds with one of the states below?

Prebuild configuration states

Any repo

  • OK - last webhook received at <date/time> for <event type>
  • No prebuild configured for this repo (no prebuild in gitpod.yml - file or db)

GitHub

  • Gitpod app on GitHub not installed for org or user <name>
  • Gitpod app on GitHub not configured to access <repo>

Other git integrations

  • No webhook installed for <repo> (is this possible to detect?)

cc: @gtsiolis

@gtsiolis gtsiolis added component: dashboard type: improvement Improves an existing feature or existing code feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team do-not-merge/release-note-label-needed and removed do-not-merge/release-note-label-needed labels Dec 2, 2021
@gtsiolis gtsiolis changed the title Show feedback on the project card when there's need to reconfigure the app for GitHub or reinstall the webhook for GitiLab Show feedback on the project card when there's need to reconfigure the app for GitHub or reinstall the webhook for GitLab Dec 2, 2021
@jldec
Copy link
Contributor

jldec commented Jan 1, 2022

Renaming this issue to detect and show some feedback.

Note: Hovers/tooltips can be more difficult to use on touch devices - do you have a suggestion for working around that?

@jldec jldec changed the title Show feedback on the project card when there's need to reconfigure the app for GitHub or reinstall the webhook for GitLab Detect and show feedback in project when webhooks are not configured properly Jan 1, 2022
@jldec
Copy link
Contributor

jldec commented Jan 1, 2022

@gtsiolis - as mentioned in #7011 - let's track this particular scenario in this one issue for now and try to deliver just the MVC to detect and indicate status in the dashboard first.

@jldec jldec moved this to Scheduled in 🍎 WebApp Team Jan 21, 2022
@jldec
Copy link
Contributor

jldec commented Jan 21, 2022

As an MVC to help users understand the understand the state of a prebuild configuration for a specific project:

Could we show a repository prebuild configuration status on /projects/<project-name>/prebuilds with one of the states below?

Prebuild configuration states

Any repo

  • OK - last webhook received at <date/time> for <event type>
  • No prebuild configured for this repo (no prebuild in gitpod.yml - file or db)

GitHub

  • Gitpod app on GitHub not installed for org or user <name>
  • Gitpod app on GitHub not configured to access <repo>

Other git integrations

  • No webhook installed for <repo> (is this possible to detect?)

cc: @gtsiolis

@jldec jldec changed the title Detect and show feedback in project when webhooks are not configured properly Show prebuild configuration state on the project prebuilds page Feb 1, 2022
@jldec jldec removed the status in 🍎 WebApp Team Apr 8, 2022
@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 2, 2022
@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label May 3, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
Status: No status
Development

No branches or pull requests

2 participants