Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up initial extension installation on vscode web #7409

Closed
jeanp413 opened this issue Dec 31, 2021 · 1 comment · Fixed by #8313
Closed

Clean up initial extension installation on vscode web #7409

jeanp413 opened this issue Dec 31, 2021 · 1 comment · Fixed by #8313
Assignees
Labels
editor: code (browser) team: IDE type: improvement Improves an existing feature or existing code

Comments

@jeanp413
Copy link
Member

Now that theia integration is being removed #7395, we should do some cleanup when we do the initial extension installation in vscode web.
Right now, we have some custom logic inside gp-code branch to do the extension installation, we need to simplify and move this logic to the supervisor and install the needed extension using the server argument --install-entension and install-builtin-extension

@jeanp413 jeanp413 added team: IDE type: improvement Improves an existing feature or existing code labels Dec 31, 2021
@akosyakov
Copy link
Member

Supervisor should be kept agnostic to concrete IDEs. We have though startup.sh and we could move this logic there.

@jeanp413 jeanp413 moved this to In Progress in 🚀 IDE Team Feb 18, 2022
@akosyakov akosyakov moved this from In Progress to In Review in 🚀 IDE Team Feb 21, 2022
@akosyakov akosyakov moved this from In Review to Awaiting Deployment in 🚀 IDE Team Mar 2, 2022
@jeanp413 jeanp413 moved this from Awaiting Deployment to Done in 🚀 IDE Team Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor: code (browser) team: IDE type: improvement Improves an existing feature or existing code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants