Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotfiles install.sh script doesn't fully run #7579

Closed
schickling opened this issue Jan 12, 2022 · 15 comments
Closed

Dotfiles install.sh script doesn't fully run #7579

schickling opened this issue Jan 12, 2022 · 15 comments
Labels
feature: dotfiles team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code

Comments

@schickling
Copy link

Bug description

I'm currently giving the new dotfiles feature (see #5198) a try and have been running into a few problems. It seems that my provided install.sh script is only partially executed. (I'm actually not sure what the problem is but would like to find out - is there a way to see the logs of the executed install.sh script?)

Steps to reproduce

image

  • Running the install.sh script manually seems to work

CleanShot 2022-01-12 at 23 56 02

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

Additional questions

  • Will the executed result of my dotfiles be cached, so it's instantly ready when opening any kind of (new) workspace? (This is critical for me as executing my install.sh script (mostly using Nix home-manager) can take multiple minutes)
  • How can I see the logs of the executed install.sh file?
@axonasif axonasif added feature: dotfiles type: bug Something isn't working team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code and removed type: bug Something isn't working labels Jan 13, 2022
@iQQBot
Copy link
Contributor

iQQBot commented Jan 13, 2022

You can view log in ~/.dotfiles.log

@iQQBot
Copy link
Contributor

iQQBot commented Jan 13, 2022

Will the executed result of my dotfiles be cached, so it's instantly ready when opening any kind of (new) workspace? (This is critical for me as executing my install.sh script (mostly using Nix home-manager) can take multiple minutes)

no cache here

@axonasif
Copy link
Member

You can view log in ~/.dotfiles.log

I thought that's only for symlinking logs 😅
Just checked now and it seems STDOUT and STDERROR are there too, thanks for the info!

@axonasif
Copy link
Member

@schickling basically the env profile wasn't loaded, so you need to use bash interactive mode to do that manually.
I just raised a PR schickling/dotfiles#9

@schickling
Copy link
Author

Thanks a lot @axonasif - this indeed seems to address the initial problem of the install.sh script not running properly - it now does. However...

no cache here

This turns out to be a major problem - at least for my use case where setting up the dotfiles takes multiple minutes.
This now seems to have the result of opening any kind of workspace takes multiple minutes showing this screen (i.e. making it faster to clone a repo on my local machine etc than opening it on Gitpod)

image

@schickling

This comment has been minimized.

@axonasif
Copy link
Member

@schickling yes you are right, it seems to take a bit longer to open, probably 2 minutes. But I'm unable to reproduce the other error that you mentioned. I open my PR with Gitpod and did some activities on the workspace for the last 5 minutes but nothing wrong yet.
Screenshot_20220113-154813.png

@axonasif
Copy link
Member

@schickling can you please try again and let me know if it's still happening 🙏?

@schickling

This comment has been minimized.

@axonasif
Copy link
Member

axonasif commented Jan 13, 2022

@schickling your MakeFile changes won't be persistent since you're running it from init task of .gitpod.yml

@iQQBot
Copy link
Contributor

iQQBot commented Jan 13, 2022

@schickling Did you use vscode inside? you can switch to stable

@schickling

This comment has been minimized.

@schickling
Copy link
Author

schickling commented Jan 13, 2022

Closing this issue as the mentioned problem is addressed via this:

#!/usr/bin/bash -I

However the lack of caching for dotfiles is still a major problem for me (which unfortunately renders Gitpod with dotfiles enabled impractical for me to use).

@axonasif
Copy link
Member

Closing this issue as the mentioned problem is addressed via this:

#!/usr/bin/bash -I

However the lack of caching for dotfiles is still a major problem for me (which unfortunately renders Gitpod with dotfiles enabled impractical for me to use).

I would encourage you to create a separate feature request for this 🙂

@schickling
Copy link
Author

Done: #7592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dotfiles team: webapp Issue belongs to the WebApp team type: improvement Improves an existing feature or existing code
Projects
None yet
Development

No branches or pull requests

3 participants