Skip to content

Some prebuilds are not properly linked to their project #7689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gtsiolis opened this issue Jan 19, 2022 · 6 comments
Open

Some prebuilds are not properly linked to their project #7689

gtsiolis opened this issue Jan 19, 2022 · 6 comments
Labels
component: server feature: prebuilds meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working

Comments

@gtsiolis
Copy link
Contributor

Bug description

Some incremental prebuilds link back to an non-existent (unknown) base prebuild.

For example:

See relevant discussion (internal). Cc @jankeromnes

Incremental Prebuild Base Prebuild
Screenshot 2022-01-19 at 4 50 21 PM (2) Screenshot 2022-01-19 at 4 50 25 PM (2)

Steps to reproduce

N/A

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@gtsiolis gtsiolis added type: bug Something isn't working component: dashboard feature: prebuilds team: webapp Issue belongs to the WebApp team labels Jan 19, 2022
@jankeromnes
Copy link
Contributor

jankeromnes commented Jan 19, 2022

Re-posting from Slack:

the base prebuild a39f6aa4-3c6d-4447-9e44-40411b38152b actually exists in the DB, but it's not associated to a Project 🤔

{
  "id": "a39f6aa4-3c6d-4447-9e44-40411b38152b",
  "cloneUrl": "https://github.com/gitpod-io/gitpod.git",
  "commit": "ddd3ced7bf335267d0553d8ea570dc6ed7b9fc63",
  "state": "available",
  "creationTime": "2022-01-17 06:20:29.782139 UTC",
  "projectId": "",
  "branch": ""
}

The missing Project association why it doesn't show up in the UI. However, I don't know why it didn't get associated (especially since the Prebuild is recent -- from 2 days ago) 🐛

@jankeromnes
Copy link
Contributor

Found this relevant log entry:

2022-01-17T06:20:47.504446Z Query INSERT IGNORE INTO d_b_prebuilt_workspace (id, cloneURL, commit, state, creationTime, buildWorkspaceId, snapshot, error, _lastModified, projectId, branch) VALUES ('a39f6aa4-3c6d-4447-9e44-40411b38152b', 'https://github.com/gitpod-io/gitpod.git', 'ddd3ced7bf335267d0553d8ea570dc6ed7b9fc63', 'building', '2022-01-17 06:20:29.782139', 'gitpodio-gitpod-s0q6z0qt15o', '', '', '2022-01-17 06:20:31.996503', '', '');

This is creating the prebuild with state building and both projectId and branch set to ''.

There are several updates after that to change the state, and every time projectId and branch are also ''.

@jankeromnes jankeromnes changed the title Some incremental prebuilds link back to an non-existent (unknown) base prebuild Some prebuilds are not properly linked to their project Jan 31, 2022
@jankeromnes
Copy link
Contributor

Changed issue title to "Some prebuilds are not properly linked to their project" because that's the root problem (the unknown base prebuild exists, but it's just not associated with the project, thus it doesn't show up in the UI)

@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 2, 2022
@stale stale bot closed this as completed Jun 29, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Jun 29, 2022
@gtsiolis gtsiolis reopened this Jun 29, 2022
Repository owner moved this from Done to In Progress in 🍎 WebApp Team Jun 29, 2022
@gtsiolis gtsiolis removed the meta: stale This issue/PR is stale and will be closed soon label Jun 29, 2022
@geropl geropl moved this from In Progress to Scheduled in 🍎 WebApp Team Jul 6, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@gtsiolis gtsiolis added the meta: never-stale This issue can never become stale label Oct 12, 2022
@david-bakin
Copy link

david-bakin commented Oct 14, 2022

For anyone who finds this after the forced change to require a Team for access to the prebuilds page of the dashboard: You might get this "unknown prebuild" error on an initial prebuild after the conversion. Fix is apparently to check in some kind of commit (anything trivial will do, like a harmless whitespace change somewhere). That has (in at least one instance) kicked out a new prebuild properly attached to its project. (See discord discussion for example.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: server feature: prebuilds meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Status: Scheduled
Development

No branches or pull requests

4 participants