Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] add a metric for received webhook events #9170

Closed
AlexTugarev opened this issue Apr 7, 2022 · 5 comments
Closed

[server] add a metric for received webhook events #9170

AlexTugarev opened this issue Apr 7, 2022 · 5 comments
Labels
component: server feature: prebuilds meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team

Comments

@AlexTugarev
Copy link
Member

Problem to solve

Let's see the frequency of webhook events. Tough it's clear, that we want/need to decouple inrush from actually handling of those events, it would be interesting to see the impact on the current system.

@jldec
Copy link
Contributor

jldec commented May 31, 2022

Some overlap with #10341
Would like to be able to observe webhooks for specific repos (for debugging prebuilds).

@AlexTugarev AlexTugarev changed the title [server] add metrics for webhook evens [server] add a metric for received webhook events Jun 7, 2022
@AlexTugarev
Copy link
Member Author

@jldec, you are right about the overlap. Do you think merging both is necessary?

I'd like to see a metric for received webhook events per provider in order to identify spikes (or issues) and correlate with load induced.

@jldec
Copy link
Contributor

jldec commented Jun 9, 2022

Feel free to combine the 2 issues. The requirement from a support perspective is that we need to be able to trace working prebuilds from repo commit -> webhook trigger -> prebuild start -> prebuild end.

This would give us a baseline to find issues when say webhooks stop arriving from the git provider, or prebuilds are not starting because of auth for a specific user, or because of a broken git integration.

@stale
Copy link

stale bot commented Sep 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 8, 2022
@stale stale bot closed this as completed Sep 25, 2022
@stale stale bot moved this to Done in 🍎 WebApp Team Sep 25, 2022
@AlexTugarev AlexTugarev reopened this Sep 25, 2022
Repository owner moved this from Done to In Progress in 🍎 WebApp Team Sep 25, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Sep 25, 2022
@geropl geropl removed the status in 🍎 WebApp Team Sep 26, 2022
@AlexTugarev AlexTugarev self-assigned this Sep 26, 2022
@jldec jldec moved this to Scheduled in 🍎 WebApp Team Oct 2, 2022
@geropl geropl removed the status in 🍎 WebApp Team Oct 7, 2022
@stale
Copy link

stale bot commented Jan 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 2, 2023
@stale stale bot closed this as completed Jun 12, 2023
@github-project-automation github-project-automation bot moved this to In Validation in 🍎 WebApp Team Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: server feature: prebuilds meta: stale This issue/PR is stale and will be closed soon team: webapp Issue belongs to the WebApp team
Projects
Status: In Validation
Development

No branches or pull requests

3 participants