Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "with-helm=true" support from Preview Environments #9844

Closed
Tracked by #9842
meysholdt opened this issue May 7, 2022 · 4 comments · Fixed by #9964
Closed
Tracked by #9842

Remove "with-helm=true" support from Preview Environments #9844

meysholdt opened this issue May 7, 2022 · 4 comments · Fixed by #9964
Assignees
@liam-j-bennett

Comments

@meysholdt
Copy link
Member

Is your feature request related to a problem? Please describe

In preparation to delete the Helm Chart (#9842), delete the with-helm annotation support from Werft Jobs. With that change, Helm can no longer be used in preview environments.

Describe the behaviour you'd like

Delete all code that implements the following flag:

gitpod/.werft/jobs/build/job-config.ts

Line 90 in dbc5805

const withHelm = "with-helm" in buildConfig && !mainBuild;

Additional context

We should also confirm with all product teams that nobody still depends on this feature.
@meysholdt meysholdt mentioned this issue May 7, 2022
Closed
5 tasks
@meysholdt
Copy link
Member Author

meysholdt commented May 7, 2022 •
edited
Loading

We should also confirm with all product teams that nobody still depends on this feature.

Outreaches:

@meysholdt meysholdt mentioned this issue May 9, 2022
Closed
@meysholdt
Copy link
Member Author

Mads: Confirm that "with-observability" works with the installer in core-dev or decide that we don't support that in core-dev.

@meysholdt
Copy link
Member Author

with-payment should also work before we can remove with-helm:

@meysholdt
Copy link
Member Author

related: #9858.

@liam-j-bennett liam-j-bennett self-assigned this May 12, 2022
@liam-j-bennett liam-j-bennett mentioned this issue May 12, 2022
Merged
Repository owner moved this from In Progress to Done in ☁️ DevX by 🚚 Delivery and Operations Experience Team May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liam-j-bennett liam-j-bennett

Labels
None yet
Projects
No open projects
☁️ DevX by 🚚 Delivery and Operations Experience Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove with-helm and associated functions gitpod-io/gitpod
2 participants
@meysholdt @liam-j-bennett