Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Integration on Integrations page worded poorly for Self-Hosted installations #9861

Open
lucasvaltl opened this issue May 9, 2022 · 3 comments
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team

Comments

@lucasvaltl
Copy link
Contributor

Bug description

Currently, on the integrations page it says: "Manage Git integrations for self-managed instances of GitLab, GitHub, or Bitbucket." - this makes it seem like this functionality is limited to self-managed SCM instances, and does not allow you to add public SCM provider instances (i.e. SaaS versions):
Screenshot 2022-05-09 at 11 59 42

For a self-hosted installation this is confusing, because no integration for bitbucket.org, gitlab.com or github.com is set up by default. As such, you will also need to add the public/SaaS version of an SCM using the add integration mechanism, however this worded in a way that it seems like it only allows you to add self-hosted versions of the SCM providers:
Screenshot 2022-05-09 at 11 59 50

As a comparison, see this screenshot on how it looks like on gitpod.io - where bitbucket.org, gitlab.com (SaaS version) and github.com are integrated by default and the wording makes more sense:
Screenshot 2022-05-09 at 12 00 36

This is likely also linked to improving our integration docs for Self-Hosted users, which was discussed internally here.

Steps to reproduce

Spin up a self hosted instance, configure your fist git provider during the installation. Navigate to the integrations page in the dashboard.

Workspace affected

No response

Expected behavior

No response

Example repository

No response

Anything else?

No response

@lucasvaltl lucasvaltl added the bug label May 9, 2022
@gtsiolis gtsiolis added type: bug Something isn't working and removed bug labels May 9, 2022
@jldec
Copy link
Contributor

jldec commented May 22, 2022

There appears to be some confusion about cluster-wide OAuth setup vs. registering private SCMs.

The git integrations section was indeed designed for non-admin users to add private integrations under their personal settings.

Configuring cluster-wide OAuth providers typically requires admin privs and happens at install time.
This is related to #9164.

@jldec jldec removed the type: bug Something isn't working label May 22, 2022
@gtsiolis
Copy link
Contributor

Cross-posting #10142 in case this could help resolve both issues. Cc @jldec @lucasvaltl

@geropl geropl added component: dashboard team: webapp Issue belongs to the WebApp team labels Aug 1, 2022
@stale
Copy link

stale bot commented Nov 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Nov 9, 2022
@gtsiolis gtsiolis added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard meta: never-stale This issue can never become stale team: webapp Issue belongs to the WebApp team
Projects
Status: No status
Development

No branches or pull requests

4 participants