Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Set Proxy Service as ClusterIP Type in KOTS Admin UI #9981

Closed
jimmybrancaccio opened this issue May 12, 2022 · 4 comments · Fixed by #10537
Closed

Add Option to Set Proxy Service as ClusterIP Type in KOTS Admin UI #9981

jimmybrancaccio opened this issue May 12, 2022 · 4 comments · Fixed by #10537
Assignees
Labels
team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code

Comments

@jimmybrancaccio
Copy link

Is your feature request related to a problem? Please describe

For users who don't use the Proxy service as a LoadBalancer and instead have their own LoadBalancer in place, it would be very helpful to have the ability to set the Proxy service as ClusterIP instead. I believe having to manually set this has caused several failed Gitpod updates for me.

Describe the behaviour you'd like

Ideally a simple toggle in the admin UI would be excellent.

Describe alternatives you've considered

Manually editing the service for the moment (kubectl edit svc proxy -n gitpod).

Additional context

@nandajavarma nandajavarma added team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code labels May 17, 2022
@nandajavarma
Copy link
Contributor

This would in fact be a very worthy improvement to make. An immediate solution for this could be as follows:

  • We add a field to our experimental configuration to set proxyServiceType, by default being LoadBalancer
  • From KOTS UI, this can be provided as a patch in the additional configuration section.
  • We will document this as a potential work-around, and that it is experimental/might change in the future.

cc @lucasvaltl @corneliusludmann

@scasei
Copy link

scasei commented May 24, 2022

Same problem here, would be very nice to have

@Seenox
Copy link

Seenox commented Jun 7, 2022

Same issue. That would be really useful.
As far as I can tell, any changes/redeployment also reverts it back to Loadbalancer type and leaves "readiness-check-pod" in CrashLoopBackOff.

@Seenox
Copy link

Seenox commented Jul 6, 2022

@nandajavarma confirming #10537 has worked as expected for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: delivery Issue belongs to the self-hosted team type: improvement Improves an existing feature or existing code
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants