Skip to content

Commit b3d9b8d

Browse files
Dmitry NikulinByron
Dmitry Nikulin
authored andcommitted
Fix TypeError in git.execute(..., output_stream=file)
This fixes #619 - raise GitCommandError(not TypeError) when output_stream is set in git.execute
1 parent e1d2f4b commit b3d9b8d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: git/cmd.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -794,7 +794,7 @@ def _kill_process(pid):
794794
else:
795795
max_chunk_size = max_chunk_size if max_chunk_size and max_chunk_size > 0 else io.DEFAULT_BUFFER_SIZE
796796
stream_copy(proc.stdout, output_stream, max_chunk_size)
797-
stdout_value = output_stream
797+
stdout_value = proc.stdout.read()
798798
stderr_value = proc.stderr.read()
799799
# strip trailing "\n"
800800
if stderr_value.endswith(b"\n"):

0 commit comments

Comments
 (0)