Skip to content

Commit df5c941

Browse files
yarikopticByron
authored andcommitted
BF: remove ddt from requirements.txt since no ddt required at run time.
Otherwise, since requirements.txt is loaded into install_requires, any installation which manages to miss installing ddt could cause setuptools to freak out. E.g. here is a traceback from running tests of datalad ====================================================================== ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata extractor_cls = extractors[mtype_key].load() File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load self.require(*args, **kwargs) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require items = working_set.resolve(reqs, env, installer, extras=self.extras) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve raise DistributionNotFound(req, requirers) pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPython in conda environment. Original commit 74a0507 which added ddt there unfortunately does not state the reason so probably was just a slip
1 parent 5ff2f4f commit df5c941

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: requirements.txt

-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
gitdb2 (>=2.0.0)
2-
ddt>=1.1.1

0 commit comments

Comments
 (0)