refact(win_errs): move HIDE_WINDOWS_KNOWN_ERRORS from main-code to test

Author: ankostis

gitdb/test/__init__.py

@@ -2,3 +2,13 @@
 #
 # This module is part of GitDB and is released under
 # the New BSD License: http://www.opensource.org/licenses/bsd-license.php
+import os
+
+from gitdb.util import is_win
+
+
+#: We need an easy way to see if Appveyor TCs start failing,
+#: so the errors marked with this var are considered "acknowledged" ones, awaiting remedy,
+#: till then, we wish to hide them.
+HIDE_WINDOWS_KNOWN_ERRORS = is_win and os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', True)
+

gitdb/test/db/test_pack.py

@@ -13,7 +13,8 @@
 
 import os
 import random
-from gitdb.util import mman, HIDE_WINDOWS_KNOWN_ERRORS
+from gitdb.util import mman
+from gitdb.test import HIDE_WINDOWS_KNOWN_ERRORS
 
 
 class TestPackDB(TestDBBase):

gitdb/test/lib.py

@@ -2,6 +2,7 @@
 #
 # This module is part of GitDB and is released under
 # the New BSD License: http://www.opensource.org/licenses/bsd-license.php
+from gitdb.test import HIDE_WINDOWS_KNOWN_ERRORS
 """Utilities used in ODB testing"""
 from array import array
 from functools import wraps
@@ -16,8 +17,7 @@
 import tempfile
 import unittest
 
-from gitdb import OStream
-from gitdb.util import rmtree, mman, HIDE_WINDOWS_KNOWN_ERRORS
+from gitdb.util import rmtree, mman
 from gitdb.utils.compat import xrange
 
 
@@ -168,7 +168,7 @@ def make_bytes(size_in_bytes, randomize=False):
     return a.tostring()
 
 
-def make_object(type, data):
+def make_object(otype, data):
     """:return: bytes resembling an uncompressed object"""
     odata = "blob %i\0" % len(data)
     return odata.encode("ascii") + data

gitdb/util.py

@@ -84,11 +84,6 @@ def unpack_from(fmt, data, offset=0):
 
 log = logging.getLogger(__name__)
 
-#: We need an easy way to see if Appveyor TCs start failing,
-#: so the errors marked with this var are considered "acknowledged" ones, awaiting remedy,
-#: till then, we wish to hide them.
-HIDE_WINDOWS_KNOWN_ERRORS = is_win and os.environ.get('HIDE_WINDOWS_KNOWN_ERRORS', True)
-
 #{ compatibility stuff ...