LinkedIn provider could be simplified

[jamesread]

Hey @nevo-david , I'd been having some problems getting the advertising API authorized on my LinkedIn developers account, so I set about seeing if I could adjust the linkedin provider API to work without it.

I dropped r_basicprofile from the scopes, and also removed calls to /me, which seem to be deprecated in favour of /userinfo. This saves quite a few duplicate calls when setting up the integration.

This at least allows posting to work - I've had a quick scan through the rest of the code and I cannot see where the advertizing API migth be used - do you know? If the advertising API is used, maybe we could hide this behind a feature flag for people that don't have the advertising API enabled?

I'll just post the quick diff below, but in principle if I turned this into a PR, would this work for you?

diff --git a/libraries/nestjs-libraries/src/integrations/social/linkedin.provider.ts b/libraries/nestjs-libraries/src/integrations/social/linkedin.provider.ts
index 441e908..564918d 100644
--- a/libraries/nestjs-libraries/src/integrations/social/linkedin.provider.ts
+++ b/libraries/nestjs-libraries/src/integrations/social/linkedin.provider.ts
@@ -19,7 +19,7 @@ export class LinkedinProvider extends SocialAbstract implements SocialProvider {
   identifier = 'linkedin';
   name = 'LinkedIn';
   isBetweenSteps = false;
-  scopes = ['openid', 'profile', 'w_member_social', 'r_basicprofile'];
+  scopes = ['openid', 'profile', 'w_member_social'];
   refreshWait = true;
 
   async refreshToken(refresh_token: string): Promise<AuthTokenDetails> {
@@ -42,19 +42,7 @@ export class LinkedinProvider extends SocialAbstract implements SocialProvider {
       })
     ).json();
 
-    const { vanityName } = await (
-      await this.fetch('https://api.linkedin.com/v2/me', {
-        headers: {
-          Authorization: `Bearer ${accessToken}`,
-        },
-      })
-    ).json();
-
-    const {
-      name,
-      sub: id,
-      picture,
-    } = await (
+    const userinfo = await (
       await this.fetch('https://api.linkedin.com/v2/userinfo', {
         headers: {
           Authorization: `Bearer ${accessToken}`,
@@ -63,13 +51,13 @@ export class LinkedinProvider extends SocialAbstract implements SocialProvider {
     ).json();
 
     return {
-      id,
+      id: userinfo.sub,
       accessToken,
       refreshToken,
       expiresIn: expires_in,
-      name,
-      picture,
-      username: vanityName,
+      name: userinfo.name,
+      picture: userinfo.picture,
+      username: userinfo.name,
     };
   }
 
@@ -122,6 +110,7 @@ export class LinkedinProvider extends SocialAbstract implements SocialProvider {
 
     this.checkScopes(this.scopes, scope);
 
+    /*
     const {
       name,
       sub: id,
@@ -133,23 +122,26 @@ export class LinkedinProvider extends SocialAbstract implements SocialProvider {
         },
       })
     ).json();
+    */
 
-    const { vanityName } = await (
-      await this.fetch('https://api.linkedin.com/v2/me', {
+    const userinfo = await (
+      await this.fetch('https://api.linkedin.com/v2/userinfo', {
         headers: {
           Authorization: `Bearer ${accessToken}`,
         },
       })
     ).json();
 
+    console.log("Linkedin userinfo", userinfo);
+
     return {
-      id,
+      id: userinfo.sub,
       accessToken,
       refreshToken,
       expiresIn,
-      name,
-      picture,
-      username: vanityName,
+      name: userinfo.name,
+      picture: userinfo.picture,
+      username: userinfo.name,
     };
   }