Skip to content

Navigation improvement #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pomozoff opened this issue Nov 23, 2022 · 7 comments
Closed

Navigation improvement #1447

pomozoff opened this issue Nov 23, 2022 · 7 comments
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pomozoff
Copy link

Is your feature request related to a problem? Please describe.
I'm always frustrated when trying to navigate through a plenty of remote branches by up and down arrows.

Describe the solution you'd like

  1. Add PgUp and PgDown shortcuts.
  2. Add a filter text field. I believe it would be useful not only in the "branch" window.

Describe alternatives you've considered
Nothing more.

Additional context
Nothing to add.

@extrawurst
Copy link
Collaborator

  1. totally agreed.
  2. is a dup of Search branch #1350

lets make this issue about adding pageup/down support in the branch list view

@extrawurst extrawurst added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 23, 2022
@extrawurst extrawurst added this to the v0.23 milestone Nov 23, 2022
@ObiWanRohan
Copy link

Looks like 1 is already present. The PgUp and PgDn keys are working in the branch list view.

@pomozoff
Copy link
Author

Good news!
How do they work on a MacBook?

@ObiWanRohan
Copy link

I am on Linux with a full keyboard so I directly have the keys.
Can you try with fn + Up Arrow and fn + Down Arrow?

Here's where the scroll is implemented.
https://github.com/extrawurst/gitui/blob/b59526c86c3faaac29716fe472f322c134a52305/src/components/branchlist.rs#L231-L246

@pomozoff
Copy link
Author

Yes, that works.

@extrawurst
Copy link
Collaborator

so this can be closed then?

@pomozoff
Copy link
Author

I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants