Skip to content

When entering Chinese information, the pop-up window does not follow the cursor #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oriming opened this issue May 25, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@oriming
Copy link

oriming commented May 25, 2023

Describe the bug
When entering Chinese information, the pop-up window does not follow the cursor.

To Reproduce
Steps to reproduce the behavior:

  1. Commit
  2. Enter submission information

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

  • macOS 13.1
  • GitUI 0.22.1
  • Rust 1.69.0
  • Alacritty 0.12.1
2023-05-25.21.05.06.mov
@oriming oriming added the bug Something isn't working label May 25, 2023
@extrawurst
Copy link
Collaborator

is that only the case for Chinese?

@oriming
Copy link
Author

oriming commented May 26, 2023

@extrawurst This is a program bug and has nothing to do with the language.

@eclairevoyant
Copy link

I can reproduce on Linux with other languages. The issue is the IME candidate input or candidate list should be aligned to the cursor, but in gitui it bounces between aligning to the bottom right corner of the modal and the top left of the app itself.

I assume this is not an upstream issue because other ratatui-based programs I tested (ttyper, systeroid) don't appear to have this behavior

@extrawurst
Copy link
Collaborator

is that still an issue with 0.25 and the new textarea implementation?

@ZCShou
Copy link

ZCShou commented Feb 28, 2024

is that still an issue with 0.25 and the new textarea implementation?

Yes. I tested in windows terminal on windows 11 and ubuntu 20.04 , see the following picture.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants