isBinaryFileSync + isBinaryFile

[thom4parisot]

Reading the README, it is very strange to have isBinaryFileSync being async just because the second argument is a function.

Having the distinct functions would at least match Node.js sync/async declarations.

In any case, having a *Sync async function is just bad in term of naming.

[gjtorikian]

I think the README is just totally wrong. The async function is called isBinaryFile. The sync version is....also called isBinaryFile.

[thom4parisot]

Thanks :-)

The thing is, considering the if/else thing, it would still be more implicit to have two different functions, while keeping consistant with Node fs module (readFile and readFileSync for example).

It is just a sugar but 1) the code gets more readable 2) smaller number of lines of code in the function and 3) easier to test.

[sindresorhus]

👍 That is too magic.

What I usually do is export the async function on module.exports and then a sync function on module.exports.sync. Example: https://github.com/sindresorhus/read-chunk#api

[gjtorikian]

I'm going to implement a separate Sync method now, since there is interest.