test(filter): test expression object with inherited properties

Related to angular#9984

Author: gkalpak

src/ng/filter/filter.js

@@ -125,7 +125,7 @@ function filterFilter() {
       case 'object':
         // Replace `{$: 'xyz'}` with `'xyz'` and fall through
         var keys = Object.keys(expression);
-        if ((keys.length === 1) && (keys[0] === '$')) expression  = expression.$;
+        if ((keys.length === 1) && (keys[0] === '$')) expression = expression.$;
         // jshint -W086
       case 'boolean':
       case 'number':

test/ng/filter/filterSpec.js

@@ -156,6 +156,26 @@ describe('Filter: filter', function() {
   });
 
 
+  it('should not consider the expression\'s inherited properties', function() {
+    Object.prototype.noop = noop;
+
+    var items = [
+      {text: 'hello'},
+      {text: 'goodbye'},
+      {text: 'kittens'},
+      {text: 'puppies'}
+    ];
+
+    expect(filter(items, {text: 'hell'}).length).toBe(1);
+    expect(filter(items, {text: 'hell'})[0]).toBe(items[0]);
+
+    expect(filter(items, 'hell').length).toBe(1);
+    expect(filter(items, 'hell')[0]).toBe(items[0]);
+
+    delete(Object.prototype.noop);
+  });
+
+
   describe('should support comparator', function() {
 
     it('as equality when true', function() {