Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show system message for OMEMO status in the conversation #125

Open
ghost opened this issue Oct 4, 2018 · 5 comments
Open

Show system message for OMEMO status in the conversation #125

ghost opened this issue Oct 4, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Oct 4, 2018

Currently, lurch show the status in the conversation title. It is not so clear and not easily to be noticed.

System message could be an additional notification. We send user a message ("OMEMO", or "OMEMO available" accordingly) automatically when they create new conversation with others. OMEMO user status should be checked and verified just like what lurch_topic_update_im() do.

I'm going to work on this idea on dev branch.

@ghost
Copy link
Author

ghost commented Dec 24, 2018

Would you please review the code? it has quite been a while since last release for this plugin, is there a plan or blueprint? Thanks!

@gkdr
Copy link
Owner

gkdr commented Aug 24, 2019

Sorry for not replying, I failed to tell you how much I appreciate your contribution. As you can see on the dev branch, I was quite busy with something else. I do plan to check out all pull requests before the next release, and I didn't forget about you. Just a little more patience!

To be honest, I was reluctant to create new releases since I did not have an automated pipeline for the builds, which especially for Windows was a problem. I was working on this problem too, at least for carbons, and maybe soon I'll be able to react quicker.

@ghost
Copy link
Author

ghost commented Sep 24, 2019

It's great to get your reply. Please take your time and don't so worry about the progress. If you need helps on automation build please let me know.
I'm also in busy but I have plan to take some time on learning your codes include lurch, axc and libomemo.

@gkdr
Copy link
Owner

gkdr commented Oct 14, 2019

Would you like a code review or should I just change things myself if there is anything?

@ghost
Copy link
Author

ghost commented Oct 19, 2019

Code review. Please tell me what I should improve if there are any problems in my PR. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant