-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A 0.6.9 / 0.7.0 release? #149
Comments
I would like to, yes. I was planning to make the 0.7.0 cut after I finish the signal API and can delete the horrible current command interface code. I'm basically done with it too, but I got stuck on the "status" signal for chats: |
the query for the room config should provide this information: https://xmpp.org/extensions/xep-0045.html#disco-roominfo But as described here this setting could change anytime so that's why a client must look out for the status codes: https://xmpp.org/extensions/xep-0045.html#security-anon |
@DanScharon Thanks, that's very helpful! I wanted to use locally available information and couldn't find it in the structs the XMPP prpl provides. I just checked and the |
I think that new 0.7.0 will be here after this PR: @fortysixandtwo, @gkdr: And I hope before the Debian 11 freeze which arrives very soon... It is the time to merge... Note: The next Debian 12 will be in 2023... |
@Neustradamus the freeze does not prevent us from fixing bugs in Debian past that point - both in the freeze and even in stable releases. Please don't pressure upstream maintainers. |
@gkdr: Can you create a 0.7.0 version to have the relation with libomemo 0.7.0? Some OS has only a lurch package and not two packages: lurch + libomemo... It is really important to have the perfect OMEMO 0.3.0 with 12-byte IV to be compatible with all clients. Thanks in advance. |
regarding the feature i want for the next release: i am working on the tests. mocking away |
@gkdr: Thanks for your reply! The problem is here for example: AOSC-Dev/aosc-os-abbs#2568. |
@fortysixandtwo, @henry-nicolas: About the next "0.7.0" release, it will be always good for Debian 11? @GKR: Some OS maintainers wait the new lurch build because they have not 3 packages (axc/libomemo/lurch). Note: There is a problem with the lurch package name, never same name: |
I see 2 questions there so let's take those 2 points separately:
Something else that must be considered (if I got it right): Debian entered the transition freeze already. That means we should not upload new library version that involves API/ABI breakage which would require a transititon request to the release team - not sure if this updated version would fall into that category though (if there are breakages).
|
Furthermore, some of those names were likely chosen because they follow the same naming format for other purple plugins in the distro. So even though it's inconsistent naming for you, it's consistent naming within the distro (which, arguably, is more valuable for users of the distro...) |
@henry-nicolas: I know where are git repositories: I think that in Debian 11 Bullseye, 0.7.0 of libomemo will be a 0.6.2+git... and will be same with purple-lurch when 0.7.0 will be here...
@hartwork can help you: @craftyguy: Yes of course, I have not said that OS maintainers have taken a bad name ^^ |
@gkdr, @henry-nicolas, @fortysixandtwo: Any progress on it? |
Rest assured that this has not been forgotten and is being worked on. Thanks for your continuous interest, but please try to be patient. |
Yes, it is only because user requests to have the good OMEMO in all OS. |
I have done a PR to solve a missing part in changelog of libomemo 0.7.0. |
@Neustradamus send me a babysitter and this will be done in no time 🙂 regarding the issue i mentioned initially: i have implemented the status check via a query, but now while manually testing against prosody i witnessed the following: if a non-moderator user joins an anonymous room which is then switched to non-anonymous, the change is somehow not properly communicated to the prpl. that means that the JID is still not accessible until the room is rejoined. |
i just pushed the switch-over to the api-based command interface in c255455. it was available as |
there you go: https://github.com/gkdr/lurch/releases/tag/v0.7.0 😬 |
@gkdr: Thanks! Can you look current PRs |
by the way, @henry-nicolas - as this is a plugin for libpurple (2), i think there is no api breakage as it did not have any other interface before. now there is the signals API and i'll have to consider that when making breaking changes, but that's a problem for another day. |
Thanks for the heads up @gkdr - that is good to know |
Is there a chance to have a new release with all the nice addition since 0.6.8? It seems at least chatty (https://source.puri.sm/Librem5/chatty) expects post 0.6.8 (https://source.puri.sm/Librem5/lurch/-/commits/librem5) and with more widespread use it would be great if encryption could work out of the box and distributions prefer to package released versions.
The text was updated successfully, but these errors were encountered: