Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shapecast range intersect function return options #229

Closed
gkjohnson opened this issue Mar 11, 2021 · 2 comments
Closed

Improve shapecast range intersect function return options #229

gkjohnson opened this issue Mar 11, 2021 · 2 comments

Comments

@gkjohnson
Copy link
Owner

gkjohnson commented Mar 11, 2021

Related to #228, #218, #173

As of #228 the intersectsRange function is allowed to return true or false. false causes traversal and triangle iteration to continue while returning true stops traversal and prevents triangle traversal.

Examples like collectTriangles, selection, and sculpt might benefit from more granularity to prevent triangle iteration while still continuing traversal which would prevent unnecessary reading of the triangle vertices when they aren't being used.

  • Add three states that can be returned: CONTINUE_TRAVERSAL, SKIP_TRIANGLES, INTERSECTED
@gkjohnson gkjohnson mentioned this issue Mar 11, 2021
9 tasks
@gkjohnson gkjohnson added this to the v0.x.x milestone Mar 11, 2021
This was referenced Mar 11, 2021
@gkjohnson gkjohnson modified the milestones: v0.x.x, v0.4.0, v0.4.1 Mar 12, 2021
@gkjohnson gkjohnson modified the milestones: v0.4.1, v0.4.2 Jun 21, 2021
@gkjohnson gkjohnson modified the milestones: v0.4.2, v0.x.x, v0.4.3 Jul 17, 2021
@gkjohnson
Copy link
Owner Author

gkjohnson commented Jul 25, 2021

Alternatively all those examples could use intersectsRange instead which would likely improve performance. The collectTriangles example would require exposing SeparatingAxisTriangle publicly, though.

Change class name to ExtendedTriangle.

@gkjohnson gkjohnson modified the milestones: v0.4.3, v0.x.x Jul 25, 2021
@gkjohnson gkjohnson modified the milestones: v0.x.x, v0.4.5 Aug 20, 2021
@gkjohnson gkjohnson modified the milestones: v0.5.1, v0.5.2 Oct 5, 2021
@gkjohnson gkjohnson modified the milestones: v0.5.2, v0.5.3 Oct 25, 2021
@gkjohnson gkjohnson modified the milestones: v0.5.4, v0.5.5 Jan 8, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.7, v0.5.8 Mar 22, 2022
@gkjohnson gkjohnson added this to the v0.5.11 milestone Apr 12, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.11, v0.5.12 May 9, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.17, v0.5.18 Oct 15, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.18, v0.5.19 Nov 15, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.19, v0.5.20 Nov 28, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.20, v0.5.21, v0.5.22 Dec 31, 2022
@gkjohnson gkjohnson modified the milestones: v0.5.23, v0.5.24 Feb 3, 2023
@gkjohnson gkjohnson modified the milestones: v0.5.24, v0.6.0, v0.6.1 May 13, 2023
@gkjohnson gkjohnson modified the milestones: v0.6.1, v0.6.2 Jul 7, 2023
@gkjohnson gkjohnson modified the milestones: v0.6.2, v0.6.3, v0.6.4 Jul 19, 2023
@gkjohnson gkjohnson modified the milestones: v0.6.4, v0.x.x Aug 16, 2023
@gkjohnson
Copy link
Owner Author

Unneeded, I think, with the solo intersects range function.

@gkjohnson gkjohnson removed this from the v0.x.x milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant