Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies should be explicitly set in package.json #15

Closed
wolfd opened this issue Sep 19, 2019 · 2 comments
Closed

Dependencies should be explicitly set in package.json #15

wolfd opened this issue Sep 19, 2019 · 2 comments

Comments

@wolfd
Copy link

wolfd commented Sep 19, 2019

Everything directly imported by a file should have a package version set in package.json.
I use pnpm, which disallows relying on phantom dependencies, which causes this package to not work correctly.
For more info on phantom dependencies: https://rushjs.io/pages/advanced/phantom_deps/

https://github.com/gl-vis/gl-cone3d/blob/d686777/lib/conemesh.js#L7-L16

The dependencies that should be added to "dependencies" in package.json are:

  • colormap
  • gl-buffer
  • gl-mat4
  • gl-shader
  • gl-texture2d
  • gl-vao
  • ndarray
  • normals
  • simplicial-complex-contour
  • typedarray-pool

(this is essentially the same issue as gl-vis/gl-streamtube3d#9)

@dy
Copy link
Member

dy commented Sep 20, 2019

@archmoj it should not break anything, but still bumping deps is responsible op

@archmoj
Copy link
Contributor

archmoj commented Sep 20, 2019

Addressed in 1b64879 and 5ee973b.
Published 1.4.0
cc: @etpinard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants