Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modular Firebase admin in v1.x #488

Closed
Tracked by #265
kmjennison opened this issue Jun 6, 2022 · 3 comments
Closed
Tracked by #265

Use modular Firebase admin in v1.x #488

kmjennison opened this issue Jun 6, 2022 · 3 comments
Labels
enhancement New feature or request v1 Change intended to land in v1.x

Comments

@kmjennison
Copy link
Contributor

kmjennison commented Jun 6, 2022

Is your feature request related to a problem? Please describe.

We should take advantage of modular Firebase admin:
https://firebase.google.com/docs/admin/migrate-node-v10#use-modules-instead-of-namespaces

Describe the solution you'd like and how you'd implement it
A clear and concise description of what you want to happen.

Currently, we do:

import * as admin from 'firebase-admin'

We should use:

import { initializeApp } from 'firebase-admin/app'

Is this a breaking change?
Would this require existing users to change how they're using next-firebase-auth?

[Edited] Yes, firebase-admin would need to be v10+.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

None

@kmjennison kmjennison added the enhancement New feature or request label Jun 6, 2022
@kmjennison kmjennison mentioned this issue Jun 6, 2022
24 tasks
@louisgv
Copy link

louisgv commented Jun 18, 2022

Firebase just released v11: https://github.com/firebase/firebase-admin-node/releases/tag/v11.0.0

I will try to use it. If there's any issue, should I report them here or should I make a new one? @kmjennison

@kmjennison
Copy link
Contributor Author

@louisgv Please open a separate issue if you have a problem with v11. Thanks!

@kmjennison kmjennison added the v1 Change intended to land in v1.x label Aug 25, 2022
@kmjennison
Copy link
Contributor Author

Closed in #548.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v1 Change intended to land in v1.x
Projects
None yet
Development

No branches or pull requests

2 participants