Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lsp-types dependency #3662

Open
lpil opened this issue Oct 2, 2024 · 4 comments
Open

Upgrade lsp-types dependency #3662

lpil opened this issue Oct 2, 2024 · 4 comments
Labels
good first issue Good for newcomers help wanted Contributions encouraged priority:medium

Comments

@lpil
Copy link
Member

lpil commented Oct 2, 2024

cargo update -p lsp-types
@lpil lpil added help wanted Contributions encouraged good first issue Good for newcomers priority:medium labels Oct 2, 2024
@dzvon
Copy link
Contributor

dzvon commented Oct 3, 2024

@lpil I can take care of this.

@lpil
Copy link
Member Author

lpil commented Oct 3, 2024

Thank you

@dzvon
Copy link
Contributor

dzvon commented Oct 3, 2024

I've been trying to update, but I've hit a roadblock with the to_file_path
function. The latest lsp-types has replaced the url::Url type with
fluent_uri::Uri, which unfortunately does not have a built-in
to_file_path method. For more context, check out this issue.

Given these constraints, our options are limited:

  1. Stay put: continue using the current version.
  2. Roll our own: manually implement the to_file_path method, which is
    prone to errors.

Personally, I think it's safer to hold off on the update for now and keep an eye
on the issue.

@lpil
Copy link
Member Author

lpil commented Oct 7, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Contributions encouraged priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants