Return index of undecodable element in dynamic.list DecodeError path #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johtso
commented
Jun 9, 2024
src/gleam/list.gleam
Outdated
| [x, ..xs] -> | ||
| case fun(x) { | ||
| Ok(y) -> do_try_map_with_index(xs, fun, [y, ..acc], i + 1) | ||
| Error(error) -> Error(#(i, error)) |
There was a problem hiding this comment.
Is a tuple a reasonable data structure to use?
johtso
commented
Jun 9, 2024
src/gleam/list.gleam
Outdated
| /// try_map([[1], [], [2]], first) | ||
| /// // -> Error(#(1, Nil)) | ||
| /// ``` | ||
| pub fn try_map_with_index( |
lpil
reviewed
Jun 12, 2024
|
@lpil something like that? |
lpil
reviewed
Jun 17, 2024
src/gleam/dynamic.gleam
Outdated
Comment on lines
354
to
359
| let result = try_map_with_index(list, decoder_type) | ||
| case result { | ||
| Ok(values) -> Ok(values) | ||
| Error(#(index, errors)) -> | ||
| Error(list.map(errors, push_path(_, int.to_string(index)))) | ||
| } |
There was a problem hiding this comment.
Let's make the helper function specific
Suggested change
| let result = try_map_with_index(list, decoder_type) | |
| case result { | |
| Ok(values) -> Ok(values) | |
| Error(#(index, errors)) -> | |
| Error(list.map(errors, push_path(_, int.to_string(index)))) | |
| } | |
| let result = decode_list(list, decoder_type, 0, []) | |
| case result { | |
| Ok(values) -> Ok(values) | |
| Error(#(index, errors)) -> | |
| Error(list.map(errors, push_path(_, index))) | |
| } |
There was a problem hiding this comment.
You want it to be typed to take a Decoder rather than just an a -> b function? We already have a function called decode_list.
If you have an idea for a name that doesn't conflict with the existing decode_list..
There was a problem hiding this comment.
@lpil do you think it's alright as it is now?
lpil
reviewed
Jul 8, 2024
| with fun: fn(a) -> Result(b, e), | ||
| ) -> Result(List(b), #(Int, e)) { | ||
| do_try_map_with_index(list, fun, [], 0) | ||
| } |
There was a problem hiding this comment.
These generic functions are still here, please remove them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #627
I'm new to Gleam, so fully prepared for what I'm doing here to be unidiomatic or otherwise distasteful for some reason, but thought it would be worth having a crack at it!