Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not found: Error: Cannot resolve module 'react/addons' in /apps/node_modules/skin-deep #73

Closed
cbrwizard opened this issue Apr 11, 2016 · 4 comments

Comments

@cbrwizard
Copy link

Hey, after updating React to 15.0.1 I started receiving this error when compiling with Webpack:

Module not found: Error: Cannot resolve module 'react/addons' in /apps/node_modules/skin-deep
 @ ./~/skin-deep/skin-deep.js 8:14-37

I use skin-deep@0.16.0. I didn't receive this error before updating React. This must be linked to this recent change.
Are there any plans to update this package for React 15? Thanks!

@glenjamin
Copy link
Owner

Sounds like you'll need to update the bundling config you have to also exclude "react/addons" - the if statement inside the code will ensure that require will never be called.

I'll get the docs updated and bump package.json soonish.

@glenjamin
Copy link
Owner

I have confirmed that the current version appears to work fine with React 0.15.

I've updated the bundle exclusion docs and included 0.15 in the test suite in 84325b1

@glenjamin
Copy link
Owner

Feel free to re-open if you still have issues after updating your exclude config.

@cbrwizard
Copy link
Author

Hey @glenjamin thanks for the swift response!
Changing to

new webpack.IgnorePlugin(/ReactContext|react\/addons/)

resolved this error without the need to update skin-deep. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants