extmod/modmachine: Clean up decls of machine types to use common ones.

dpgeorge · dpgeorge · commit 90023b4dcf7b · 2023-10-26T16:20:53.000+11:00
The machine_i2c_type, machine_spi_type and machine_timer_type symbols are
already declared in extmod/modmachine.h and should not be declared anywhere
else.

Also move declarations of machine_pin_type and machine_rtc_type to the
common header in extmod.

Signed-off-by: Damien George &lt;damien@micropython.org&gt;
diff --git a/drivers/esp-hosted/esp_hosted_hal.c b/drivers/esp-hosted/esp_hosted_hal.c
@@ -34,9 +34,8 @@
 #include <string.h>
 
 #include "py/runtime.h"
-#include "modmachine.h"
 #include "extmod/machine_spi.h"
-#include "mpconfigboard.h"
+#include "extmod/modmachine.h"
 #ifdef MICROPY_HW_WIFI_LED
 #include "led.h"
 #endif
diff --git a/drivers/ninaw10/nina_wifi_bsp.c b/drivers/ninaw10/nina_wifi_bsp.c
@@ -35,9 +35,8 @@
 #include <string.h>
 
 #include "py/runtime.h"
-#include "modmachine.h"
 #include "extmod/machine_spi.h"
-#include "mpconfigboard.h"
+#include "extmod/modmachine.h"
 
 #include "nina_bsp.h"
 #include "nina_wifi_drv.h"
diff --git a/extmod/modmachine.h b/extmod/modmachine.h
@@ -96,7 +96,9 @@ typedef struct _machine_wdt_obj_t machine_wdt_obj_t;
 extern const mp_obj_type_t machine_adc_type;
 extern const mp_obj_type_t machine_i2c_type;
 extern const mp_obj_type_t machine_i2s_type;
+extern const mp_obj_type_t machine_pin_type;
 extern const mp_obj_type_t machine_pwm_type;
+extern const mp_obj_type_t machine_rtc_type;
 extern const mp_obj_type_t machine_spi_type;
 extern const mp_obj_type_t machine_timer_type;
 extern const mp_obj_type_t machine_uart_type;
diff --git a/ports/esp32/boards/pins_prefix.c b/ports/esp32/boards/pins_prefix.c
@@ -1,4 +1,4 @@
 #include "py/obj.h"
+#include "extmod/modmachine.h"
 #include "machine_pin.h"
-#include "modmachine.h"
 #include "genhdr/pins.h"
diff --git a/ports/esp32/machine_hw_spi.c b/ports/esp32/machine_hw_spi.c
@@ -32,7 +32,7 @@
 #include "py/stream.h"
 #include "py/mphal.h"
 #include "extmod/machine_spi.h"
-#include "modmachine.h"
+#include "extmod/modmachine.h"
 
 #include "driver/spi_master.h"
 #include "soc/gpio_sig_map.h"
diff --git a/ports/esp32/machine_i2c.c b/ports/esp32/machine_i2c.c
@@ -28,7 +28,7 @@
 #include "py/mphal.h"
 #include "py/mperrno.h"
 #include "extmod/machine_i2c.h"
-#include "modmachine.h"
+#include "extmod/modmachine.h"
 
 #include "driver/i2c.h"
 #include "hal/i2c_ll.h"
diff --git a/ports/esp32/machine_pin.c b/ports/esp32/machine_pin.c
@@ -35,9 +35,10 @@
 
 #include "py/runtime.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
+#include "extmod/virtpin.h"
 #include "mphalport.h"
 #include "modmachine.h"
-#include "extmod/virtpin.h"
 #include "machine_pin.h"
 #include "machine_rtc.h"
 #include "modesp32.h"
diff --git a/ports/esp32/machine_rtc.c b/ports/esp32/machine_rtc.c
@@ -36,8 +36,8 @@
 #include "py/obj.h"
 #include "py/runtime.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
 #include "shared/timeutils/timeutils.h"
-#include "modmachine.h"
 #include "machine_rtc.h"
 
 typedef struct _machine_rtc_obj_t {
diff --git a/ports/esp32/modmachine.h b/ports/esp32/modmachine.h
@@ -9,14 +9,9 @@ typedef enum {
     MACHINE_WAKE_DEEPSLEEP=0x04
 } wake_type_t;
 
-extern const mp_obj_type_t machine_timer_type;
-extern const mp_obj_type_t machine_pin_type;
 extern const mp_obj_type_t machine_touchpad_type;
 extern const mp_obj_type_t machine_adcblock_type;
 extern const mp_obj_type_t machine_dac_type;
-extern const mp_obj_type_t machine_i2c_type;
-extern const mp_obj_type_t machine_spi_type;
-extern const mp_obj_type_t machine_rtc_type;
 extern const mp_obj_type_t machine_sdcard_type;
 
 void machine_init(void);
diff --git a/ports/esp8266/modmachine.h b/ports/esp8266/modmachine.h
@@ -5,7 +5,6 @@
 
 extern const mp_obj_type_t pyb_pin_type;
 extern const mp_obj_type_t pyb_rtc_type;
-extern const mp_obj_type_t pyb_i2c_type;
 extern const mp_obj_type_t machine_hspi_type;
 
 MP_DECLARE_CONST_FUN_OBJ_VAR_BETWEEN(pyb_info_obj);
diff --git a/ports/mimxrt/boards/mimxrt_prefix.c b/ports/mimxrt/boards/mimxrt_prefix.c
@@ -2,6 +2,7 @@
 
 #include "py/obj.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
 #include "pin.h"
 
 #define PIN_AF(_name, _af_mode, _input_daisy, _instance, _input_register, _pad_config) \
diff --git a/ports/mimxrt/machine_i2c.c b/ports/mimxrt/machine_i2c.c
@@ -28,7 +28,7 @@
 #include "py/mphal.h"
 #include "py/mperrno.h"
 #include "extmod/machine_i2c.h"
-#include "modmachine.h"
+#include "extmod/modmachine.h"
 #include CLOCK_CONFIG_H
 #include "pin.h"
 
diff --git a/ports/mimxrt/machine_rtc.c b/ports/mimxrt/machine_rtc.c
@@ -29,6 +29,7 @@
 #include "py/runtime.h"
 #include "shared/runtime/mpirq.h"
 #include "shared/timeutils/timeutils.h"
+#include "extmod/modmachine.h"
 #include "modmachine.h"
 #include "ticks.h"
 #include "fsl_snvs_lp.h"
diff --git a/ports/mimxrt/machine_spi.c b/ports/mimxrt/machine_spi.c
@@ -29,7 +29,7 @@
 #include "py/mphal.h"
 #include "py/mperrno.h"
 #include "extmod/machine_spi.h"
-#include "modmachine.h"
+#include "extmod/modmachine.h"
 #include CLOCK_CONFIG_H
 
 #include "fsl_cache.h"
diff --git a/ports/mimxrt/machine_uart.c b/ports/mimxrt/machine_uart.c
@@ -73,8 +73,6 @@ typedef struct _iomux_table_t {
     uint32_t configRegister;
 } iomux_table_t;
 
-extern const mp_obj_type_t machine_uart_type;
-
 STATIC const uint8_t uart_index_table[] = MICROPY_HW_UART_INDEX;
 STATIC LPUART_Type *uart_base_ptr_table[] = LPUART_BASE_PTRS;
 static const iomux_table_t iomux_table_uart[] = {
diff --git a/ports/mimxrt/modmachine.h b/ports/mimxrt/modmachine.h
@@ -29,11 +29,7 @@
 
 #include "py/obj.h"
 
-extern const mp_obj_type_t machine_i2c_type;
-extern const mp_obj_type_t machine_rtc_type;
 extern const mp_obj_type_t machine_sdcard_type;
-extern const mp_obj_type_t machine_spi_type;
-extern const mp_obj_type_t machine_timer_type;
 
 void machine_adc_init(void);
 void machine_pin_irq_deinit(void);
diff --git a/ports/mimxrt/pin.c b/ports/mimxrt/pin.c
@@ -25,6 +25,7 @@
  */
 
 #include "py/runtime.h"
+#include "extmod/modmachine.h"
 #include "pin.h"
 
 
diff --git a/ports/mimxrt/pin.h b/ports/mimxrt/pin.h
@@ -140,7 +140,6 @@ typedef struct _machine_pin_irq_obj_t {
 
 // ------------------------------------------------------------------------------------------------------------------ //
 
-extern const mp_obj_type_t machine_pin_type;
 extern const mp_obj_type_t machine_pin_af_type;
 
 // ------------------------------------------------------------------------------------------------------------------ //
diff --git a/ports/nrf/modules/machine/i2c.c b/ports/nrf/modules/machine/i2c.c
@@ -35,6 +35,7 @@
 #if MICROPY_PY_MACHINE_I2C
 
 #include "extmod/machine_i2c.h"
+#include "extmod/modmachine.h"
 #include "i2c.h"
 #if NRFX_TWI_ENABLED
 #include "nrfx_twi.h"
diff --git a/ports/nrf/modules/machine/i2c.h b/ports/nrf/modules/machine/i2c.h
@@ -29,8 +29,6 @@
 
 #include "extmod/machine_i2c.h"
 
-extern const mp_obj_type_t machine_i2c_type;
-
 void i2c_init0(void);
 
 #endif // I2C_H__
diff --git a/ports/nrf/modules/machine/modmachine.h b/ports/nrf/modules/machine/modmachine.h
@@ -28,8 +28,6 @@
 #ifndef __MICROPY_INCLUDED_NRF5_MODMACHINE_H__
 #define __MICROPY_INCLUDED_NRF5_MODMACHINE_H__
 
-#include "py/mpstate.h"
-#include "py/nlr.h"
 #include "py/obj.h"
 
 void machine_init(void);
diff --git a/ports/nrf/modules/machine/spi.c b/ports/nrf/modules/machine/spi.c
@@ -36,6 +36,7 @@
 #include "py/nlr.h"
 #include "py/mphal.h"
 #include "extmod/machine_spi.h"
+#include "extmod/modmachine.h"
 #include "pin.h"
 #include "genhdr/pins.h"
 #include "spi.h"
diff --git a/ports/nrf/modules/machine/spi.h b/ports/nrf/modules/machine/spi.h
@@ -27,7 +27,6 @@
 #include "py/obj.h"
 
 typedef struct _machine_hard_spi_obj_t machine_hard_spi_obj_t;
-extern const mp_obj_type_t machine_spi_type;
 
 void spi_init0(void);
 void spi_transfer(const machine_hard_spi_obj_t * self,
diff --git a/ports/nrf/modules/machine/timer.c b/ports/nrf/modules/machine/timer.c
@@ -24,8 +24,8 @@
  * THE SOFTWARE.
  */
 
-#include "py/nlr.h"
 #include "py/runtime.h"
+#include "extmod/modmachine.h"
 #include "timer.h"
 #include "nrfx_timer.h"
 
diff --git a/ports/nrf/modules/machine/timer.h b/ports/nrf/modules/machine/timer.h
@@ -27,8 +27,6 @@
 #ifndef TIMER_H__
 #define TIMER_H__
 
-extern const mp_obj_type_t machine_timer_type;
-
 void timer_init0(void);
 
 #endif // TIMER_H__
diff --git a/ports/renesas-ra/boards/ra_pin_prefix.c b/ports/renesas-ra/boards/ra_pin_prefix.c
@@ -4,6 +4,7 @@
 
 #include "py/obj.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
 #include "pin.h"
 
 #define PIN_AD(p_name, p_pin, ad_bit, ad_channel) \
diff --git a/ports/renesas-ra/machine_i2c.c b/ports/renesas-ra/machine_i2c.c
@@ -32,7 +32,7 @@
 #include "py/mphal.h"
 #include "py/mperrno.h"
 #include "extmod/machine_i2c.h"
-#include "modmachine.h"
+#include "extmod/modmachine.h"
 
 #include "ra_i2c.h"
 
diff --git a/ports/renesas-ra/machine_pin.c b/ports/renesas-ra/machine_pin.c
@@ -31,9 +31,10 @@
 
 #include "py/runtime.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
+#include "extmod/virtpin.h"
 #include "shared/runtime/mpirq.h"
 #include "modmachine.h"
-#include "extmod/virtpin.h"
 
 #include "pin.h"
 #include "extint.h"
diff --git a/ports/renesas-ra/machine_rtc.c b/ports/renesas-ra/machine_rtc.c
@@ -28,6 +28,7 @@
 #include <stdio.h>
 
 #include "py/runtime.h"
+#include "extmod/modmachine.h"
 #include "shared/timeutils/timeutils.h"
 #include "extint.h"
 #include "rtc.h"
diff --git a/ports/renesas-ra/machine_spi.c b/ports/renesas-ra/machine_spi.c
@@ -32,10 +32,10 @@
 #include "py/mphal.h"
 #include "py/mperrno.h"
 #include "extmod/machine_spi.h"
+#include "extmod/modmachine.h"
 #include "pin.h"
 #include "spi.h"
 #include "ra/ra_spi.h"
-#include "modmachine.h"
 
 typedef struct _machine_hard_spi_obj_t {
     mp_obj_base_t base;
diff --git a/ports/renesas-ra/main.c b/ports/renesas-ra/main.c
@@ -41,6 +41,7 @@
 #include "lib/littlefs/lfs1_util.h"
 #include "lib/littlefs/lfs2.h"
 #include "lib/littlefs/lfs2_util.h"
+#include "extmod/modmachine.h"
 #include "extmod/vfs.h"
 #include "extmod/vfs_fat.h"
 #include "extmod/vfs_lfs.h"
diff --git a/ports/renesas-ra/modmachine.h b/ports/renesas-ra/modmachine.h
@@ -29,15 +29,9 @@
 
 #include "py/obj.h"
 
-extern const mp_obj_type_t machine_timer_type;
-extern const mp_obj_type_t machine_pin_type;
 extern const mp_obj_type_t machine_touchpad_type;
 extern const mp_obj_type_t machine_adcblock_type;
 extern const mp_obj_type_t machine_dac_type;
-extern const mp_obj_type_t machine_i2c_type;
-extern const mp_obj_type_t machine_spi_type;
-extern const mp_obj_type_t machine_i2s_type;
-extern const mp_obj_type_t machine_rtc_type;
 extern const mp_obj_type_t machine_sdcard_type;
 
 
diff --git a/ports/renesas-ra/modos.c b/ports/renesas-ra/modos.c
@@ -26,6 +26,7 @@
  */
 
 #include "py/runtime.h"
+#include "extmod/modmachine.h"
 #include "uart.h"
 #include "rng.h"
 
diff --git a/ports/renesas-ra/mpbthciport.c b/ports/renesas-ra/mpbthciport.c
@@ -29,9 +29,9 @@
 #include "py/stream.h"
 #include "py/mphal.h"
 #include "extmod/modbluetooth.h"
+#include "extmod/modmachine.h"
 #include "extmod/mpbthci.h"
 #include "shared/runtime/softtimer.h"
-#include "modmachine.h"
 #include "mpbthciport.h"
 #include "uart.h"
 
diff --git a/ports/renesas-ra/pin.h b/ports/renesas-ra/pin.h
@@ -58,7 +58,6 @@ typedef struct {
     const pin_ad_obj_t *ad;
 } machine_pin_obj_t;
 
-extern const mp_obj_type_t machine_pin_type;
 extern const mp_obj_type_t pin_af_type;
 
 // Include all of the individual pin objects
diff --git a/ports/renesas-ra/rtc.h b/ports/renesas-ra/rtc.h
@@ -28,7 +28,6 @@
 #define MICROPY_INCLUDED_RA_RTC_H
 
 #include "py/obj.h"
-extern const mp_obj_type_t machine_rtc_type;
 
 typedef struct
 {
diff --git a/ports/renesas-ra/uart.h b/ports/renesas-ra/uart.h
@@ -89,7 +89,6 @@ typedef struct _machine_uart_obj_t {
     mp_irq_obj_t *mp_irq_obj;           // user IRQ object
 } machine_uart_obj_t;
 
-extern const mp_obj_type_t machine_uart_type;
 extern const mp_irq_methods_t uart_irq_methods;
 
 void uart_init0(void);
diff --git a/ports/rp2/boards/rp2_prefix.c b/ports/rp2/boards/rp2_prefix.c
@@ -1,6 +1,7 @@
 #include <stdint.h>
 #include "py/obj.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
 #include "machine_pin.h"
 
 #define AF(af_idx, af_fn, af_unit)                      \
diff --git a/ports/rp2/machine_i2c.c b/ports/rp2/machine_i2c.c
@@ -28,7 +28,7 @@
 #include "py/mphal.h"
 #include "py/mperrno.h"
 #include "extmod/machine_i2c.h"
-#include "modmachine.h"
+#include "extmod/modmachine.h"
 
 #include "hardware/i2c.h"
 
diff --git a/ports/rp2/machine_pin.c b/ports/rp2/machine_pin.c
@@ -29,10 +29,11 @@
 
 #include "py/runtime.h"
 #include "py/mphal.h"
+#include "extmod/modmachine.h"
+#include "extmod/virtpin.h"
 #include "shared/runtime/mpirq.h"
 #include "modmachine.h"
 #include "machine_pin.h"
-#include "extmod/virtpin.h"
 
 #include "hardware/irq.h"
 #include "hardware/regs/intctrl.h"
diff --git a/ports/rp2/machine_pin.h b/ports/rp2/machine_pin.h
@@ -59,7 +59,6 @@ typedef struct _machine_pin_obj_t {
     const machine_pin_af_obj_t *af;
 } machine_pin_obj_t;
 
-extern const mp_obj_type_t machine_pin_type;
 extern const mp_obj_type_t machine_pin_af_type;
 
 // Include all of the individual pin objects
diff --git a/ports/rp2/machine_rtc.c b/ports/rp2/machine_rtc.c
@@ -35,10 +35,10 @@
 #include "py/runtime.h"
 #include "py/mphal.h"
 #include "py/mperrno.h"
+#include "extmod/modmachine.h"
 #include "shared/timeutils/timeutils.h"
 #include "hardware/rtc.h"
 #include "pico/util/datetime.h"
-#include "modmachine.h"
 
 typedef struct _machine_rtc_obj_t {
     mp_obj_base_t base;
diff --git a/ports/rp2/machine_spi.c b/ports/rp2/machine_spi.c
diff --git a/ports/rp2/modmachine.h b/ports/rp2/modmachine.h
diff --git a/ports/samd/machine_i2c.c b/ports/samd/machine_i2c.c
diff --git a/ports/samd/machine_rtc.c b/ports/samd/machine_rtc.c
diff --git a/ports/samd/machine_spi.c b/ports/samd/machine_spi.c
diff --git a/ports/samd/modmachine.h b/ports/samd/modmachine.h
diff --git a/ports/samd/pin_af.c b/ports/samd/pin_af.c
diff --git a/ports/samd/samd_spiflash.c b/ports/samd/samd_spiflash.c
diff --git a/ports/stm32/machine_i2c.c b/ports/stm32/machine_i2c.c
diff --git a/ports/stm32/machine_spi.c b/ports/stm32/machine_spi.c
diff --git a/ports/stm32/modmachine.h b/ports/stm32/modmachine.h
diff --git a/ports/stm32/spi.c b/ports/stm32/spi.c
diff --git a/ports/stm32/spi.h b/ports/stm32/spi.h
diff --git a/ports/zephyr/machine_i2c.c b/ports/zephyr/machine_i2c.c
diff --git a/ports/zephyr/machine_pin.c b/ports/zephyr/machine_pin.c
diff --git a/ports/zephyr/machine_spi.c b/ports/zephyr/machine_spi.c
diff --git a/ports/zephyr/modmachine.h b/ports/zephyr/modmachine.h

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@`
`28`	`28`	`#define MICROPY_INCLUDED_RA_RTC_H`
`29`	`29`
`30`	`30`	`#include "py/obj.h"`
`31`		`-extern const mp_obj_type_t machine_rtc_type;`
`32`	`31`
`33`	`32`	`typedef struct`
`34`	`33`	`{`