Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do partials correctly #329

Open
8 tasks
glenn2223 opened this issue Sep 27, 2023 · 0 comments
Open
8 tasks

Do partials correctly #329

glenn2223 opened this issue Sep 27, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@glenn2223
Copy link
Owner

glenn2223 commented Sep 27, 2023

Issue

Currently, saving a partial file compiles all non-partial files. This means that many files are potentially being compiled for no reason.

Proposal

Working on a typescript compiler has allowed me to come up with a method that correctly identifies linked files. By identifying the link I will know the saved file is a "child" and to only compile its "parent" files

Possible Breaking Changes

  • May make partialsList setting redundant.
    • However, people may still want a file compiled that is included by another file. Will need to think about this

TODO

  • Implement the new method
  • Use the save event to update the records
  • Save the records to keep load times short
  • Change the start-up method to:
    • check for changes if the data exists
    • create the data if it doesn't exist
  • Update readme and docs

Should resolve/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant