Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should retry logic be added #36

Open
colinclerk opened this issue Oct 8, 2020 · 1 comment
Open

Should retry logic be added #36

colinclerk opened this issue Oct 8, 2020 · 1 comment

Comments

@colinclerk
Copy link

CRDB has documentation for adding client side retries to drivers:
https://www.cockroachlabs.com/docs/stable/advanced-client-side-transaction-retries.html

I do not see this logic in the source code (confirmed by searching for "SAVEPOINT" keyword). Should this be added to sqlboiler-crdb, or was it intentionally excluded?

@glerchundi
Copy link
Owner

I prefer to keep the generated code as simple as possible adding retry logic would complicate things a lot and the maintenance time would be much more.

Furthermore I think that retry can be "easily" applied at the driver level (by creating a wrapping driver or something similar) as well making it a cleaner solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants