Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-height images in Glitch-soc TL when Letterbox disabled #1641

Open
mstdn opened this issue Nov 27, 2021 · 5 comments
Open

Full-height images in Glitch-soc TL when Letterbox disabled #1641

mstdn opened this issue Nov 27, 2021 · 5 comments
Labels

Comments

@mstdn
Copy link

mstdn commented Nov 27, 2021

Steps to reproduce the problem

Meow, meow! <3

Personally I very much like the "default" way of media display in the timelines when option "Crop images in non-expanded posts to 16x9" is disabled. In the Glitch-soc flavour this works a little different since we have the Letterbox feature.

I wonder if it where possible to have full-height images on the Glitch-soc flavour when Letterbox is disabled and the option "Crop images in non-expanded posts to 16x9" is also disabled in settings, this would make sense since it would "fallback" to the default vanilla option :-)

  1. Disable Letterbox media
  2. Disable "Crop images in non-expanded posts to 16x9"
  3. Media in TL gets cropped
    ...

Schermafbeelding 2021-11-27 om 14 48 38

Schermafbeelding 2021-11-27 om 14 47 57

Schermafbeelding 2021-11-27 om 14 47 43

Schermafbeelding 2021-11-27 om 14 47 21

Expected behaviour

When both options are disabled, media should show in full-height

Actual behaviour

Media gets cropped (option (Crop images in non-expanded posts to 16x9) gets ignored

Specifications

Latest Glitch-soc

@mstdn mstdn added the bug label Nov 27, 2021
@mstdn
Copy link
Author

mstdn commented Jan 7, 2022

Bump! And little question on this one.. Is this a bug or intentional? Since I see that in the vanilla flavour the full-height does fully work :-)

@ClearlyClaire
Copy link

It was marked as postponed in #1240 and it hasn't been ported to glitch-soc. The code around here is pretty different so it'd be more work than the usual porting, plus the interaction with glitch-soc's extra options isn't obvious

@Sirs0ri
Copy link

Sirs0ri commented Jul 8, 2023

have there been any more developments around this feature?

@tarrien
Copy link

tarrien commented Jul 19, 2023

Not to be a pest and pile on, but this is definitely an issue that would be nice to have fixed.

@DragonMinded
Copy link

Adding on my own vote for full height non-cropped previews in glitch-soc :3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants