-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-height images in Glitch-soc TL when Letterbox disabled #1641
Comments
Bump! And little question on this one.. Is this a bug or intentional? Since I see that in the vanilla flavour the full-height does fully work :-) |
It was marked as postponed in #1240 and it hasn't been ported to glitch-soc. The code around here is pretty different so it'd be more work than the usual porting, plus the interaction with glitch-soc's extra options isn't obvious |
have there been any more developments around this feature? |
Not to be a pest and pile on, but this is definitely an issue that would be nice to have fixed. |
Adding on my own vote for full height non-cropped previews in glitch-soc :3 |
Steps to reproduce the problem
Meow, meow! <3
Personally I very much like the "default" way of media display in the timelines when option "Crop images in non-expanded posts to 16x9" is disabled. In the Glitch-soc flavour this works a little different since we have the Letterbox feature.
I wonder if it where possible to have full-height images on the Glitch-soc flavour when Letterbox is disabled and the option "Crop images in non-expanded posts to 16x9" is also disabled in settings, this would make sense since it would "fallback" to the default vanilla option :-)
...
Expected behaviour
When both options are disabled, media should show in full-height
Actual behaviour
Media gets cropped (option (Crop images in non-expanded posts to 16x9) gets ignored
Specifications
Latest Glitch-soc
The text was updated successfully, but these errors were encountered: