-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip fields #67
Skip fields #67
Conversation
@abhidg - this works, but it's taking nearly double the time to run on larger datasets. Any ideas which bit might be slowing it down/ ways to get the speed back up? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #67 +/- ##
==========================================
- Coverage 89.10% 87.63% -1.48%
==========================================
Files 4 4
Lines 716 760 +44
==========================================
+ Hits 638 666 +28
- Misses 78 94 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- slowdown is probably due to more nested if blocks, Python is not that good with multiple conditionals in for-loops. Could you add some documentation examples? Thanks!
Thanks! |
This PR allows certain fields, or field patterns, to be skipped if not present in the data, to use when a single study has multiple datasets with a varying amount of data entry.