Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add examples for dateFormatter with date and time formats #273

Closed
jzaefferer opened this issue Jun 10, 2014 · 9 comments
Closed

Docs: Add examples for dateFormatter with date and time formats #273

jzaefferer opened this issue Jun 10, 2014 · 9 comments

Comments

@jzaefferer
Copy link
Contributor

There's really just one example for formatDate, which uses datetime. Would be good to have more examples.

Maybe also provide links or more docs to what the various formats actually mean, e.g. what does a medium time format look like. Currently there are no details nor references for that.

EDIT: https://github.com/jquery/globalize/blob/master/doc/api/date/format.md#example

@jzaefferer jzaefferer changed the title Docs: Add examples for formatNumber with date and time formats Docs: Add examples for formatDate with date and time formats Jun 10, 2014
@rxaviers
Copy link
Member

Very well observed. We should add examples using skeletons, date, and time.

@rxaviers rxaviers added this to the 1.0.0 milestone Jun 10, 2014
@rxaviers rxaviers removed this from the 1.0.0 milestone Aug 27, 2014
@rxaviers
Copy link
Member

  • Exemplify every supported date pattern.

@jzaefferer
Copy link
Contributor Author

@manrajgrover
Copy link
Contributor

@jzaefferer sir @rxaviers sir,

I would like to take this issue up. Please guide me. I feel one example each would be suffice. Any particular date and time to follow? Also should I follow the same pattern for documentation as for dateFormatter() ?

@rxaviers
Copy link
Member

@jzaefferer this seems already implemented. What do you think of our current doc at https://github.com/jquery/globalize/blob/master/doc/api/date/date-formatter.md?

@rxaviers
Copy link
Member

Should we add a similar table to the presetValues one demonstrating several skeletons?

@rxaviers rxaviers changed the title Docs: Add examples for formatDate with date and time formats Docs: Add examples for dateFormatter with date and time formats Mar 13, 2015
@manrajgrover
Copy link
Contributor

Yes @rxaviers sir. I thought there was a need of giving code sample for each of date , time and skeleton.

Treating myself as a new user of library for the first time and want to use skeletons, I do feel there is need of more information for skeleton and samples. I think yes adding demonstrations of several skeletons to the documentation will fix this.

@jzaefferer
Copy link
Contributor Author

Adding a similar table with examples for skeletons sounds good. Should mention the limited timezone support (see comment above or #202).

@rxaviers
Copy link
Member

So, let's go for it. @manrajgrover feel free to ping me on IRC needing any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants