Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongodb 3.4.x support #27

Closed
feliixx opened this issue Sep 4, 2017 · 4 comments
Closed

Mongodb 3.4.x support #27

feliixx opened this issue Sep 4, 2017 · 4 comments

Comments

@feliixx
Copy link

feliixx commented Sep 4, 2017

Currently some features of MongoDB 3.4.x are implemented ( collations for example) but aren't documented ( Query.Collation(), views...), and some other aren't implemented at all (see #484 )

In addition, test aren't run against mongo 3.4.x in Travis CI, so it's not very clear whether this serie is supported or not.

So is there any plans to fully support Mongodb 3.4?

If nobody is working on this, I'm interested in doing it !

@domodwyer
Copy link

Hi @feliixx

So 3.4 is supported (but as you said, partially) - I'm very interested in the appName parameter (https://github.com/go-mgo/mgo/issues/484) and was planning on implementing it myself when I had the time - if you'd like to, please do! I'll help however I can :)

Obviously views are a good nice-to-have and may become more of a priority for us in the future, I haven't looked into how much work they'd take to implement though.

The tests are somewhat tricker - I had a quick go at getting them running against 3.4 when we originally forked mgo, but the whole test harness thing is less than perfect... Again, if you want to/can, I'll help however I can!

Thanks,
Dom

@domodwyer
Copy link

As a side note, we'll happily host the 3.4 binaries for the travis tests if you decide to have a crack at it - just let us know and we'll get them uploaded.

Dom

@feliixx
Copy link
Author

feliixx commented Sep 5, 2017

@domodwyer Thanks, that would be great ! I started working on appName parameter, see PR #28

@domodwyer
Copy link

domodwyer commented Sep 5, 2017

Hey @feliixx, thanks for the PR!

I've split this issue into individual feature request issues so we can close them as we go along:

I'm going to close this ticket and switch to the above :) Thanks for bringing it up (and if you have any more, please do open issues!)

Dom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants