You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've had requests come in to add the local webbrowser integration used by the CLI to the SDK.
To start, the feature request:
Allow SDK users to emulate the login behavior of globus login
That probably breaks into components:
A GlobusSDKAuthCodeHandlerServer which can be used as a context manager to cover both the local HTTP server and webbrowser invocation
Handling for custom HTML templates
Handling for custom scopes and other params on the oauth2 flow
Well-defined exceptions for different failure modes (instead of catching Exception)
When you start to add in all of the window-dressing features (like detecting remote connections), it will inevitably bloat a bit more.
After spending a couple of hours trying to figure out how to slot it in, I'm convinced.
It doesn't belong in the SDK.
This is only being requested as an SDK feature "by process of elimination" -- people want to emulate globus login, and they're not sure where else to request such a feature.
When you look at what we offer today, we have the APIs, Local Globus Connect Personal, and various objects to support these. Authorizers, Responses, and Exceptions are all the most minimal, necessary tooling for managing these things.
The CLI is a python product which will do all kinds of things which users want to emulate -- but not all of them need to be here in the SDK. If such things need to be shared and exposed to 3rd party developers (and I'm not convinced that there is any such need!), then let's make another lib rather than distorting this one and losing sight of its goals and the level of quality and support which it offers.
Maybe it will make its way in, against my protestations, but it would be a mistake that sets a really bad precedent.
The text was updated successfully, but these errors were encountered:
We've had requests come in to add the local
webbrowser
integration used by the CLI to the SDK.To start, the feature request:
That probably breaks into components:
GlobusSDKAuthCodeHandlerServer
which can be used as a context manager to cover both the local HTTP server andwebbrowser
invocationException
)When you start to add in all of the window-dressing features (like detecting remote connections), it will inevitably bloat a bit more.
After spending a couple of hours trying to figure out how to slot it in, I'm convinced.
It doesn't belong in the SDK.
This is only being requested as an SDK feature "by process of elimination" -- people want to emulate
globus login
, and they're not sure where else to request such a feature.When you look at what we offer today, we have the APIs, Local Globus Connect Personal, and various objects to support these. Authorizers, Responses, and Exceptions are all the most minimal, necessary tooling for managing these things.
The CLI is a python product which will do all kinds of things which users want to emulate -- but not all of them need to be here in the SDK. If such things need to be shared and exposed to 3rd party developers (and I'm not convinced that there is any such need!), then let's make another lib rather than distorting this one and losing sight of its goals and the level of quality and support which it offers.
Maybe it will make its way in, against my protestations, but it would be a mistake that sets a really bad precedent.
The text was updated successfully, but these errors were encountered: