Error saving assigned

[vitormarques86]

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

Version

10.0.1

Bug description

After assigning a ticket to a user, when I try to save, the screen goes blank.

Relevant log output

Uncaught Exception TypeError: Argument 1 passed to Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier() must be of the type string, array given, called in /var/www/html/glpi/src/DBmysql.php on line 1257 in /var/www/html/glpi/src/Toolbox/Sanitizer.php at line 228

Page URL

No response

Steps To reproduce

No response

Your GLPI setup information

No response

Anything else?

No response

[cedric-anne]

Hi,

Have you some active plugins ? In this case, try to deactivate them (especially behaviours plugin) to see if problem persist.

[cconard96]

I see the same error when adding any actors to tickets.
I haven't been able to track down the cause completely yet, but it doesn't seem related to plugins and seemed to have started with a commit merged yesterday or today.

[vitormarques86]

Even with the plugins disabled, the problem persists.

[vitormarques86]

Happened after upgrading to version 10.0.1

[brunnersm]

Me too, after upgrading to version 10.0.1
[2022-06-02 15:46:57] glpiphplog.CRITICAL: *** Uncaught Exception TypeError: Argument 1 passed to Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier() must be of the type string, array given, called in /var/www/html/src/DBmysql.php on line 1257 in /var/www/html/src/Toolbox/Sanitizer.php at line 228
Backtrace :
src/DBmysql.php:1257 Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier()
src/DBmysql.php:1288 DBmysql::quoteValue()
src/DBmysql.php:1312 DBmysql->buildInsert()
src/CommonDBTM.php:705 DBmysql->insert()
src/CommonDBTM.php:1297 CommonDBTM->addToDB()
src/CommonITILObject.php:3006 CommonDBTM->add()
src/CommonITILObject.php:1716 CommonITILObject->addAdditionalActors()
src/Ticket.php:1303 CommonITILObject->prepareInputForUpdate()
src/CommonDBTM.php:1565 Ticket->prepareInputForUpdate()
front/ticket.form.php:84 CommonDBTM->update()

[ariasfonseca]

Hi, me too not technical aggregation for ticket. event log error:

[2022-06-02 16:11:18] glpiphplog.CRITICAL: *** Uncaught Exception TypeError: Argument 1 passed to Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier() must be of the type string, array given, called in /var/www/html/glpi/src/DBmysql.php on line 1257 in /var/www/html/glpi/src/Toolbox/Sanitizer.php at line 228
Backtrace :
src/DBmysql.php:1257 Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier()
src/DBmysql.php:1288 DBmysql::quoteValue()
src/DBmysql.php:1312 DBmysql->buildInsert()
src/CommonDBTM.php:705 DBmysql->insert()
src/CommonDBTM.php:1297 CommonDBTM->addToDB()
src/CommonITILObject.php:2987 CommonDBTM->add()
src/CommonITILObject.php:1716 CommonITILObject->addAdditionalActors()
src/Ticket.php:1303 CommonITILObject->prepareInputForUpdate()
src/CommonDBTM.php:1565 Ticket->prepareInputForUpdate()
front/ticket.form.php:84 CommonDBTM->update()

[OlegusPF]

Hi
We resolved this problem. I don.t know is it fully correct or not, but it is work :)
You need to change in the file /glpi/src/Toolbox/Sanitizer.php 228 string to
.... isNsClassOrCallableIdentifier($value) ....
and change the string 231 to
... , (string)$value, ...

[cedric-anne]

Hi We resolved this problem. I don.t know is it fully correct or not, but it is work :) You need to change in the file /glpi/src/Toolbox/Sanitizer.php 228 string to .... isNsClassOrCallableIdentifier($value) .... and change the string 231 to ... , (string)$value, ...

Well, you just hide the problem, and it will probably add corrupted data into your database, so it is not a good idea.

[OlegusPF]

ok, thanks, i was revert it back. waiting for resolve )

[dani]

I have the same issue on one instance of GLPI, but on another instance, I can't reproduce. Both are almost similar. Have been upgraded from 10.0.0 to 10.0.1 today, running on AlmaLinux with the same version of PHP (8.0.19) and almost the same MariaDB (10.6.7 vs 10.6.8). I'm trying to figure out the difference which make the problem reproducible.

[wevrard]

in my fresh update from 10.0.1, i have a same error.

[2022-06-03 16:12:02] glpiphplog.CRITICAL: *** Uncaught Exception TypeError: Argument 1 passed to Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier() must be of the type string, array given, called in /var/www/html/glpi/src/DBmysql.php on line 1257 in /var/www/html/glpi/src/Toolbox/Sanitizer.php at line 228
Backtrace :
src/DBmysql.php:1257 Glpi\Toolbox\Sanitizer::isNsClassOrCallableIdentifier()
src/DBmysql.php:1288 DBmysql::quoteValue()
src/DBmysql.php:1312 DBmysql->buildInsert()
src/CommonDBTM.php:705 DBmysql->insert()
src/CommonDBTM.php:1297 CommonDBTM->addToDB()
src/CommonITILObject.php:3006 CommonDBTM->add()
src/CommonITILObject.php:1716 CommonITILObject->addAdditionalActors()
src/Ticket.php:1303 CommonITILObject->prepareInputForUpdate()
src/CommonDBTM.php:1565 Ticket->prepareInputForUpdate()
front/ticket.form.php:84 CommonDBTM->update()

[cconard96]

I'm trying to figure out the difference which make the problem reproducible.

Do you have any Business Rules for Tickets on the non-working instance? Are they triggered by Add, Update or both?

[dani]

The problem is not triggered when assigning a user through the mass action button on the ticket list view

[dani]

I'm trying to figure out the difference which make the problem reproducible.

Do you have any Business Rules for Tickets on the non-working instance? Are they triggered by Add, Update or both?

Indeed, the "broken" instance has business rules (Add / Add+Update), while the working instance has no business rule at all

[cosmedd]

We have the same problem with GLPI 10.0.1

It didn't happen with GLPI 10.0 until commit 3de7b01

We can confirm that the problem persists with all plugins disabled.

Only happens when assigning or changing the status of already created tickets. It is not reproduced in new tickets after upgrading to GPI 10.0.1.

[cconard96]

Issue seems like it started with the commit from #11728 but it does not seem to be the cause directly. The code that seems to be the issue is old so I don't know why the issue hasn't presented before now.

The issue would only affect updates from the form (not massive actions) because of the different way it handles actors.

[dani]

I can confirm that adding a single business rule (triggered on Add/Update) is enough to make my working instance broken too

[cosmedd]

Hello, for us it seems that the problem starts with this commit: eef8275 that is the one indicated by cconard96

Also, as dani points out, if you don't use business rules for tickets, the bug is not reproduced.

[dani]

Can we safely revert this single commit so we can assign tickets again ? (waiting for a proper fix)

[cosmedd]

Regardless of whether or not it is safe to revert it at the very least I can confirm that it is not done cleanly. That is, it would be necessary to revert more commits or perform a manual cleanup.

[brunnersm]

I copied 10.0.0/src/RuleTicketcCollection.php to production and it fixed the problem, until the fix came.

[ariasfonseca]

thanks @brunnersm this solution work for me

[brunoproza]

@brunnersm this solution work for me too, Tks

[vitormarques86]

@brunnersm tks!

[cmoreno038]

I only found this difference

[OlegusPF]

@cmoreno038
After hiding the lines this solution works for me. THX

[DooBio]

Hello

I'm sorry but the fix doesn't work for me.
I am in 10.0.1 and I have modified line 130 to 148 the file src/RuleTicketCollection.php

// append _actors values to awaited indexes by rule engine
        if (isset($input['_actors']) && count($input['_actors'])) {
            foreach (['requester', 'observer', 'assign'] as $actortype) {
                if (isset($input['_actors'][$actortype]) && count($input['_actors'][$actortype])) {
                    foreach ($input['_actors'][$actortype] as $actor) {
                        $input_key = "_" .
                                    getForeignKeyFieldForItemType($actor['itemtype']) .
                                    "_" .
                                    $actortype;

                        if (!isset($input[$input_key])) {
                            $input[$input_key] = [];
                        }

                        $input[$input_key][] = $actor['items_id'];
                    }
                }
            }
        }

In my ticket when I want to add an actor and I save I come across this blank page "http://.../glpi/front/ticket.form.php?id=2022002385"

and I confirm via the Action button I have no assignment problem

Thanks for your help

[DooBio]

After applying : #11812

I confirm it works

Thx 😉

[paulopera]

I'm facing the same problem on some tickets (NOT ALL) BUT if I use the Associate Myself button it works.
I can't assign only on SOME tickets to another technician but myself.
After I sent the comment I saw the DooBio comment and indeed, applying the pull #11812 fixed the problem.

[mulbzh]

I don't find where is the solution in #11812, what is the code to change ?

[mulbzh]

Ok, i found the code to change, there is a way to download all the file with the new code ?

[DooBio]

Here is the commit link Commit 30cf046

I just made the changes made by cconard96

[DamBn]

Hello

I don't find where is the solution in #11812 what is the code to change ?
/src/ticket.php is no fonctional

[paulopera]

as @DooBio mentioned above here's the direct commit link or you can download the file (backup the original first) and replace in you environment.
What you mean /src/ticket.php is not functional?
Did you check the permissions?

[DamBn]

@paulopera I replaced the ticket.php file but nothing changes. I'm using PHP 8.0.5 does this have impact ?

[variamus]

I copied 10.0.0/src/RuleTicketcCollection.php to production and it fixed the problem, until the fix came.

It's working. However, is it safe to do ? No database corruption or anything else ?
Thanks

[cedric-anne]

Hi,

It should be fixed by #11957.