Replies: 1 comment
-
definitely no time to experiment any further in this direction |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I am already working on a branch that spins off worker threads to do the sass transformations and the benchmark shows a good 33% speed improvement. I could push it further and do practically most of the work for each import in a worker thread and I reckon it would be even better.
But, by introducing worker threads I can make it more difficult for the users to pass in functions as options to the plugin because there should be restrictions on what these functions can do.
For example these functions cannot reference anything outside of their scope. One could still work around this limitation with require and other techniques but it definitely requires more skills.
I could default to
workers: false
to preserve the capability of writing arbitrary functions and possibly emitting a warning ifworkers: true
as a warning like "Here be dragons"...but maybe that's lameThat's why I opened the discussions so that I can hear your suggestions...
Beta Was this translation helpful? Give feedback.
All reactions